[Fixed] MODELDEF scaling affects normals

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

MODELDEF scaling affects normals

Postby Marisa Kirisame » Wed Nov 18, 2020 7:30 pm

This is something that I found out by accident while running some tests. As it turns out, normals on models appear to be affected by modeldef scaling, even though... they technically shouldn't?

A sample to reproduce this bug is linked here. The effects can be seen by having SSAO on and setting gl_ssao_debug to 4.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: MODELDEF scaling affects normals

Postby Marisa Kirisame » Fri Dec 11, 2020 5:02 pm

OK, this was an ABSOLUTELY TRIVIAL fix, I only had to change two lines in main.vp. I'm opening a PR.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest