[Fixed] [4.5.0] Endoom crash

[InsanityBringer]

I have no idea if this is related to this, but when closing the ENDOOM dialog after closing GZDoom g4.5.0, I reliably get a crash. However, in order to trigger it, you need to start a map first. Once a map is loaded, you can quit GZDoom, and trying to close the ENDOOM screen will cause the crash.

Crash report and .ini in case settings are important are attached.

edit: mysteriously this has stopped happening under my current settings. One of those bugs, fuun..

[InsanityBringer]

I've experimented with this further, and it seems the crash only happens if you have only used the software renderer in a session. If you start with or switch to the hardware renderer at any point when the map is loaded, it won't crash.

[Player701]

I could not reproduce the crash on my laptop. Will try on my desktop PC tomorrow. However, I discovered another issue with ENDOOM during testing.

[drfrag]

I cannot reproduce it with the OpenGL backend.

[InsanityBringer]

Hmm, yeah, I guess it's a vulkan thing, since I basically always use vulkan. It doesn't happen on OpenGL here.

[Graf Zahl]

It does not crash my current buuld and I can remember having done something about this alreeady.

[InsanityBringer]

I just tried it on the 4.6.0 release and it still seems to be crashing. Guessing then it's an AMD thing, whee. There's stuff in the vulkan validation output but I have no idea if any of it is going to affect this.

Probably not super useful due to that, but crash report attached just in case.

[Zhs2]

Can confirm the crash happens in 4.6.0 after exiting to ENDOOM and clicking to close in Vulkan with the software renderer. I have a RX 6700 XT, latest AMD drivers 21.5.2. Here's my crash report.

[Rachael]

It's not an AMD thing I managed to get it to crash on both AMD and NVidia.

Zhs's post gave some clue as to how to reproduce it effectively - it seems that the software renderer must be in use, you must quit from the menu to the endoom screen, and try to close the endoom screen with the big red X at the top of the window.

As far as I can tell, what happens is, it's calling the Vulkan destructors after Vulkan has already been destroyed. I don't really know how to fix this, other than nulling it out, but I don't really know what needs to be nulled.

[Graf Zahl]

fixed.

The problem was that the software drawer wasn't taken down before the rest of the backend and got hung up on stale pointers.