[Fixed] re: GZDoom 4.5.0 released

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

re: GZDoom 4.5.0 released

Postby Hirogen2 » Sat Oct 31, 2020 10:25 am

Anyone seen this before?
Code: Select allExpand view
gzdoom-g4.5.0> mkdir build; cd build; cmake ..; make
[...]
[ 1222s] /usr/bin/make  -f wadsrc_widescreen/CMakeFiles/game_widescreen_gfx_pk3.dir/build.make wadsrc_widescreen/CMakeFiles/game
_widescreen_gfx_pk3.dir/build
[ 1222s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build'
[ 1222s] [100%] Generating ../game_widescreen_gfx.pk3
[ 1222s] cd /home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build/wadsrc_widescreen && ../tools/zipdir/zipdir -udf /home/abuild/rpmbui
ld/BUILD/gzdoom-g4.5.0/build/game_widescreen_gfx.pk3 /home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/wadsrc_widescreen/static
[ 1222s] Could not read central directory from /home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build/game_widescreen_gfx.pk3. (Is it a zipfile?)
[ 1222s] Will proceed as if -u had not been specified.
[ 1222s] Could not rename /home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build/game_widescreen_gfx.pk3.temp to /home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build/game_widescreen_gfx.pk3: No such file or directory
[ 1222s] /home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build/game_widescreen_gfx.pk3 contains 0 files (updated 0)
[ 1222s] cd /home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build/wadsrc_widescreen && /usr/bin/cmake -E copy_if_different /home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build/game_widescreen_gfx.pk3 /home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build/game_widescreen_gfx.pk3
[ 1222s] Error copying file (if different) from "/home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build/game_widescreen_gfx.pk3" to "/home/abuild/rpmbuild/BUILD/gzdoom-g4.5.0/build/game_widescreen_gfx.pk3".
[ 1222s] make[2]: *** [wadsrc_widescreen/CMakeFiles/game_widescreen_gfx_pk3.dir/build.make:84: game_widescreen_gfx.pk3] Error 1
User avatar
Hirogen2
 
Joined: 19 Jul 2003
Location: Central Germany
Github ID: jengelh
Operating System: RedHat-like Linux (RHEL, Fedora, CentOS, etc) 64-bit
Graphics Processor: Intel (Modern GZDoom)

Re: GZDoom 4.5.0 released

Postby Graf Zahl » Sat Oct 31, 2020 10:40 am

Did you check out the submodule?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: re: GZDoom 4.5.0 released

Postby _mental_ » Sat Oct 31, 2020 11:36 am

Actually, it’s a bug. This happens on the second build attempt with no submodule checked out.
It seems to be zipdir issue which created broken empty archive during the first run.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: re: GZDoom 4.5.0 released

Postby Hirogen2 » Sat Oct 31, 2020 4:36 pm

So I fell prey to autogenerated source archives which have little benefit over `git clone` I figure.

Normally, when source tarballs are made, a certain standard is customary; such includes, for example, running autoreconf (where applicable), pulling submodules for completeness, and/or making GPG signatures.
Would it be possible to do so in the future?
User avatar
Hirogen2
 
Joined: 19 Jul 2003
Location: Central Germany
Github ID: jengelh
Operating System: RedHat-like Linux (RHEL, Fedora, CentOS, etc) 64-bit
Graphics Processor: Intel (Modern GZDoom)

Re: re: GZDoom 4.5.0 released

Postby Graf Zahl » Sun Nov 01, 2020 1:32 am

Hirogen2 wrote:So I fell prey to autogenerated source archives which have little benefit over `git clone` I figure.


That's plain idiocy by Github to not include the submodules.
Regarding a better setup, the submodule is only transient. I didn't want to include all those graphics in the repo while they are still being worked on.
Once they are all done and complete the submodule will go away.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: re: GZDoom 4.5.0 released

Postby _mental_ » Sun Nov 01, 2020 2:26 am

Fixed zipdir issue with empty file update.
_mental_
 
 
 
Joined: 07 Aug 2011


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest