[Fixed] Inconsistency with the simplified menu

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Inconsistency with the simplified menu

Postby drfrag » Mon Oct 26, 2020 11:13 am

I don't know if it's a bug but in the new simple menu the submenus (customize controls) are right below the options title while in the old menu there's a separation, the distance between the options title and the submenus themselves is much higher and there's a gap. Same happens into the submenus.
I see there's a lack of Linespacing and Position definitions in the simplified menu.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Inconsistency with the simplified menu

Postby Rachael » Mon Oct 26, 2020 11:32 am

Most of these changes are intentional.

The idea is to group and coalesce options that are similar in end-user appearance rather than back-end functionality.

They should only be separated if intuitively and you know nothing about the inner workings of rendering engines or GZDoom, they would seem irrelevant to one another. Or if the total number of options take up more than a page.

This is much more of a science of intuition than it is a technical one - and that is why Graf wanted people who are less technically inclined to help out with the design of it. (And I think he's right)
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Inconsistency with the simplified menu

Postby drfrag » Mon Oct 26, 2020 12:36 pm

I'm not talking about the contents of the menus but the gap between the red title and the first smaller white title below, it also happens in only some of the submenus.
I could either fill the definitions for those menus or add blank lines.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Inconsistency with the simplified menu

Postby Rachael » Mon Oct 26, 2020 1:52 pm

Oh, sure. Go for it.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Inconsistency with the simplified menu

Postby Nash » Mon Oct 26, 2020 5:12 pm

Image

Code: Select allExpand view

OptionMenu 
"OptionsMenuSimple" protected
{
    
Title "$OPTMNU_TITLE"
    
Submenu "$OPTMNU_CONTROLS",            "CustomizeControls"
    
Submenu "$OPTMNU_MOUSE",            "MouseOptions"
    
Submenu "$OPTMNU_JOYSTICK",            "JoystickOptions"
 


Code: Select allExpand view

OptionMenu 
"OptionsMenu" protected
{
    
Title "$OPTMNU_TITLE"
    
Submenu "$OPTMNU_CONTROLS",            "CustomizeControls"
    
Submenu "$OPTMNU_MOUSE",            "MouseOptions"
    
Submenu "$OPTMNU_JOYSTICK",            "JoystickOptions"
 


Hmm, it seems both menus are doing the exact same thing here, yet for some reason the simple variants don't have the 1 line of space after the title. I wonder what could be causing this?
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes

Re: Inconsistency with the simplified menu

Postby drfrag » Mon Oct 26, 2020 5:54 pm

I think it's the lack of Linespacing and Position definitions as i've said.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Inconsistency with the simplified menu

Postby Graf Zahl » Tue Oct 27, 2020 12:35 am

The problem comes from the file naming. The 'simple' menu is loaded first because its name sorts alphabetically lower so it does not pick up the defaults.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Inconsistency with the simplified menu

Postby drfrag » Tue Oct 27, 2020 2:15 am

Thanks, then the best option IMO is to rename the full menu to menudef.full.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Inconsistency with the simplified menu

Postby drfrag » Tue Oct 27, 2020 2:36 am

User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest