Inconsistency with the simplified menu

[drfrag]

I don't know if it's a bug but in the new simple menu the submenus (customize controls) are right below the options title while in the old menu there's a separation, the distance between the options title and the submenus themselves is much higher and there's a gap. Same happens into the submenus.
I see there's a lack of Linespacing and Position definitions in the simplified menu.

[Rachael]

Most of these changes are intentional.

The idea is to group and coalesce options that are similar in end-user appearance rather than back-end functionality.

They should only be separated if intuitively and you know nothing about the inner workings of rendering engines or GZDoom, they would seem irrelevant to one another. Or if the total number of options take up more than a page.

This is much more of a science of intuition than it is a technical one - and that is why Graf wanted people who are less technically inclined to help out with the design of it. (And I think he's right)

[drfrag]

I'm not talking about the contents of the menus but the gap between the red title and the first smaller white title below, it also happens in only some of the submenus.
I could either fill the definitions for those menus or add blank lines.

[Rachael]

Oh, sure. Go for it.

[Nash]

Code: Select all

OptionMenu "OptionsMenuSimple" protected
{
    Title "$OPTMNU_TITLE"
    Submenu "$OPTMNU_CONTROLS",            "CustomizeControls"
    Submenu "$OPTMNU_MOUSE",            "MouseOptions"
    Submenu "$OPTMNU_JOYSTICK",            "JoystickOptions"
 

Code: Select all

OptionMenu "OptionsMenu" protected
{
    Title "$OPTMNU_TITLE"
    Submenu "$OPTMNU_CONTROLS",            "CustomizeControls"
    Submenu "$OPTMNU_MOUSE",            "MouseOptions"
    Submenu "$OPTMNU_JOYSTICK",            "JoystickOptions"
 

Hmm, it seems both menus are doing the exact same thing here, yet for some reason the simple variants don't have the 1 line of space after the title. I wonder what could be causing this?

[drfrag]

I think it's the lack of Linespacing and Position definitions as i've said.

[Graf Zahl]

The problem comes from the file naming. The 'simple' menu is loaded first because its name sorts alphabetically lower so it does not pick up the defaults.

[drfrag]

Thanks, then the best option IMO is to rename the full menu to menudef.full.

[drfrag]

It works, done a PR. https://github.com/coelckers/gzdoom/pull/1229