[Fixed] Calling DepleteAmmo in DECORATE crashes.

[Accensus]

Tested on GZDoom g4.4pre-326-g3dfb417f0 x64.

1. give CrashyPistol
2. use CrashyPistol

I assume this isn't an issue only with DepleteAmmo; it just so happened that it crashed on me with that. If I use it in an anonymous function, it errors out properly (i.e. complains about trying to call it with incompatible self-pointer, which isn't gonna happen in DECORATE).

Code: Select all • Expand view

Actor CrashyPistol : Pistol
{
   States
   {
      Fire:
          PISG A 4 DepleteAmmo(false, false, 1)
          PISG B 6 A_FirePistol
          PISG C 4
          PISG B 5 A_ReFire
          Goto Ready
   }
}


Attached CrashReport.zip.

[Graf Zahl]

DepleteAmmo cannot be used from DECORATE. The function would be called with the wrong parameters, but unfortunately the compiler cannot easily detect this. The function needs to be visible for ZScript to compile, but that means it's also visible to DECORATE. Only functions whose name starts with A_ are DECORATE safe. Adding any restriction here could block valid use cases.

[phantombeta]

DepleteAmmo cannot be used from DECORATE. The function would be called with the wrong parameters, but unfortunately the compiler cannot easily detect this. The function needs to be visible for ZScript to compile, but that means it's also visible to DECORATE. Only functions whose name starts with A_ are DECORATE safe. Adding any restriction here could block valid use cases.

I told him to make this report. The point of it is not that he thinks it should work - he knows that, it's the crash that's the issue.

[Graf Zahl]

I don't know how to plug this in DECORATE.

[_mental_]

Fixed in 0e84739.