[since 3607ffa] 'ictionary' is freed outside the GC process.

[m8f]

Steps to reproduce:
1. Start any game (e.g. Doom 2) with ictionary.pk3 loaded.

ictionary.pk3

(544 Bytes) Downloaded 16 times

2. Save the game.
3. Load the saved game.
4. Open console. Console says:

Code: Select all

Warning: 'ictionary' is freed outside the GC process.

This warning is introduced with commit 3607ffa, which is my fix for Dictionary memory leak.

Code to cause the error (the same as in the attached pk3):

Code: Select all

class ictionaryEventHandler : EventHandler
{
  override void WorldLoaded(WorldEvent e)
  {
    dict = Dictionary.Create();
  }

  Dictionary dict;
}

Is it severe? How do I fix it?

Edit: OnRegister was changed to WorldLoaded. The warning is the same.

[Major Cooke]

You're not supposed to use OnRegister for that unfortunately. Graf made a commit long ago that stated it should only ever be used for setting the order. If I recall correctly, isn't it called whenever a game is loaded?

See this commit.

The only way I can see this problem getting solved is if there's a WorldPreLoaded function being called before anything else since WorldLoaded appears to be called after everything's spawned in.

[m8f]

That's a surprise. Thanks for the info!

So, the only function that can be called in OnRegister is SetOrder?

Should I update the wiki, then? Right now it says "Initialization can be performed here." in OnRegister description.

Unfortunately, after changing OnRegister to WorldLoaded the warning stays there. The test pk3 is updated in the OP.

[Graf Zahl]

The original event handler system had a few serious design flaws, and worse, some mods depend on these design flaws or at least a resonable emulation of the bad behavior.

The message you get comes from explicitly deleting a GC'd object - you shouldn't do that but call Destroy() instead.

[m8f]

Pull request: https://github.com/coelckers/gzdoom/pull/1088