Building broken on Linux after CMakeLists change

[Gutawer]

This commit https://github.com/coelckers/gzdoom/com ... 06ab22cb2e appears to have broken the CMakeLists and stops it from building on my machine with the error message:

Code: Select all

CMake Error at src/CMakeLists.txt:1459 (install):
  install FILES given directory
  "/home/gutawer/gzdoom/build/Release/soundfonts" to install.

The line in question is:

Code: Select all

install(FILES "${PROJECT_BINARY_DIR}/soundfonts" "${PROJECT_BINARY_DIR}/fm_banks"
		DESTINATION ${INSTALL_SOUNDFONT_PATH}
		COMPONENT "Soundfont resources")

As far as I can tell it's trying to use the FILES form of the install command to install a directory.

[Graf Zahl]

Why was this even merged? I only noticed that it got in after the fact.

[_mental_]

Well, only install rule is broken. I never tried it to be honest. Travis doesn't check it too.
If someone won't do a PR with a fix soon, let's just revert that change.

[Rachael]

Why was this even merged? I only noticed that it got in after the fact.

It looked okay on Travis and the changes seemed very minor, that's why I merged it.

[drfrag]

I tested it on windows and it forced a full rebuild, then it gave a cmd error and did a partial rebuild with no more errors.
What was that shit supposed to be for? Seems someone made that PR without testing it first. Reverted here.

[Rachael]

That's the last time I trust that guy's PR's.

[Rachael]

Reverted.

If someone wants to fix that, it can be done in another full PR.