[Fixed] Ambient Occlusion gets Amplified with MSAA on and portals.

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Ambient Occlusion gets Amplified with MSAA on and portals.

Postby XxMiltenXx » Tue Apr 23, 2019 7:30 am

As it says in the title. In some instances, enabling (and raising) the MSAA setting amplifies the Ambient Occlusion Effect (set on "High" in the test case), Portals with AO set to 4. I observed this in "Winter's Fury", however, in Doom 2 MAP01, this doesn't happen. Only Vulkan is affected. OpenGL works fine.

MSAA Off:
MSAA_Off.png


MSAA 32x:
MSAA_32x.png


Winter's Fury Download: https://www.doomworld.com/forum/topic/6 ... ters-fury/

EDIT: This seems to be a portal bug. Winter's Fury uses portals. If you raise the number of "Portals" with AO, it'll get amplified. Depending on the position, the ambient occlusion effect might even vanish completely (if you go to the left of the building for example).
XxMiltenXx
 
Joined: 08 Jan 2014
Location: Germany
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: nVidia with Vulkan support

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Postby dpJudas » Sun May 05, 2019 4:24 pm

Pushed a fix for this.
dpJudas
 
 
 
Joined: 28 May 2016

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Postby XxMiltenXx » Sun May 05, 2019 6:31 pm

Only partially resolved. When MSAA is changed the ambient occlusion effect won't get amplified anymore.

However, having portals and raising "Portals with AO" still amplifies the Ambient Occlusion Effect.
XxMiltenXx
 
Joined: 08 Jan 2014
Location: Germany
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: nVidia with Vulkan support

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Postby dpJudas » Sun May 05, 2019 6:35 pm

Do you have a position I can use with the warp command to see this better? I'm not sure I'm standing the right place.
dpJudas
 
 
 
Joined: 28 May 2016

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Postby Nash » Sun May 05, 2019 6:37 pm



It's not limited to MSAA only. I get this effect with FXAA too. Easy to reproduce in Kinsie's test map http://thekinsie.com/crap/kinstest.zip ("map test" in console) from the position in the picture. Walk forward from here, until the mirror is visible from the room to the left.
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Postby XxMiltenXx » Sun May 05, 2019 6:42 pm

Just at the beginning starting position of the first map I can see that effect already. Just look at the grass, the frozen lake to the left or the big entrance building, or the ledge of the ceiling of the cave you start in:

Ambient Occlusion High, Portals with AO = 2
Screenshot_Doom_20190506_013817.png



Ambient Occlusion High, Portals with AO = 4
Screenshot_Doom_20190506_013828.png


The grass is much darker in the latter and the other differences mentioned above.

@Nash: I do not have this issue with FXAA, at least not with the latest version.
XxMiltenXx
 
Joined: 08 Jan 2014
Location: Germany
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: nVidia with Vulkan support

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Postby dpJudas » Mon May 13, 2019 3:15 pm

Fixed the portal bug.
dpJudas
 
 
 
Joined: 28 May 2016

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Postby Darkcrafter » Wed May 15, 2019 5:06 am

God I absolutely hate fake occlussion, they put it everywhere in modern games! I always let it off in the settings if it's possible. It even adds up to a player's hud weapons as it gets closer to a ground or wall, so there appears a dark "glowing" around. And it doesn't happen in real life because it heavily depends on lighting. Wisdom 3d artists from vray and mental ray schools know a real name for such a cheap technique - dirt shader.
User avatar
Darkcrafter
 
Joined: 23 Sep 2017
Location: South Russia
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Postby Rachael » Wed May 15, 2019 6:49 am

This isn't really relevant for a development ticket thread. :|

You really should've made a new thread in off-topic for such a comment.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Graphics Processor: nVidia with Vulkan support


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 2 guests