[4.0] dithered SSAO in Vulkan

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Nash
 
 
Posts: 17433
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

[4.0] dithered SSAO in Vulkan

Post by Nash »




(Click to see full resolution image)

Top: OpenGL
Bottom: Vulkan

SSAO appears to look dithered in Vulkan. I am using the "low" setting (gl_ssao = 1)
dpJudas
 
 
Posts: 3036
Joined: Sat May 28, 2016 1:01 pm

Re: [4.0] dithered SSAO in Vulkan

Post by dpJudas »

Seems the depth blur isn't applied for some reason. How did you create those pictures? Not using the debug cvars I hope. :)
User avatar
Nash
 
 
Posts: 17433
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: [4.0] dithered SSAO in Vulkan

Post by Nash »

Use gl_texture 0 to turn off the level textures. :D
dpJudas
 
 
Posts: 3036
Joined: Sat May 28, 2016 1:01 pm

Re: [4.0] dithered SSAO in Vulkan

Post by dpJudas »

Seems this one is going to be hard to fix. Spent hours on it now getting absolutely nowhere. Every type of debugging I've done says the input to the depthblur shader is correct. Yet, somehow in OpenGL mode it works but in Vulkan mode it doesn't.

To make it even weirder, if I hardcode the push constant values in the shader the Vulkan version also works. Yet RenderDoc says the values I push are the correct and same values.. At this point I've started to wonder if it is a Nvidia driver bug. :(
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.0] dithered SSAO in Vulkan

Post by Graf Zahl »

Have you been able to cross-check this with someone on Intel or AMD hardware? It may also be a problem with the GLSL compiler and not the driver.
dpJudas
 
 
Posts: 3036
Joined: Sat May 28, 2016 1:01 pm

Re: [4.0] dithered SSAO in Vulkan

Post by dpJudas »

No, I only own a computer with a NVidia card. The disassembly in RenderDoc seem to indicate the GLSL compiler itself is generating valid output, but maybe the SPIR-V compiler (in the driver) breaks.

If someone with a Intel or AMD card could take a screenshot with gl_ssao_debug 1 and gl_ssao_debug 2 output that'd be appreciated (latest vulkan2 branch build, not 4.0).
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [4.0] dithered SSAO in Vulkan

Post by _mental_ »

RX Vega 64, gl_ssao_debug 1
amd_gl_ssao_debug_1.png
gl_ssao_debug 2
amd_gl_ssao_debug_2.png
dpJudas
 
 
Posts: 3036
Joined: Sat May 28, 2016 1:01 pm

Re: [4.0] dithered SSAO in Vulkan

Post by dpJudas »

Thanks _mental_. That confirms it is a NVidia issue since debug 1 seems to have blured it just fine.
dpJudas
 
 
Posts: 3036
Joined: Sat May 28, 2016 1:01 pm

Re: [4.0] dithered SSAO in Vulkan

Post by dpJudas »

This one should be fixed now. Rewrote the entire shader to workaround whatever it was that (apparently) broke NVidia's driver.
Post Reply

Return to “Closed Bugs [GZDoom]”