Page 2 of 2
Re: [4.0.0] Where's the "Ouch" face?
Posted: Sat Jun 08, 2019 5:03 am
by Player701
I wish I did... I'd have submitted a PR long ago if I did...
That part of code is quite a mess indeed, so I'm too afraid that I'd break something else if I tried to fix it.
Sorry again.
Re: [4.0.0] Where's the "Ouch" face?
Posted: Sat Jun 08, 2019 5:05 am
by Graf Zahl
Player701 wrote:That part of code is quite a mess indeed, so I'm too afraid I'd break something else if I tried to fix it.
Welcome to the club! I think you'll understand why something this seemingly trivial doesn't get fixed. The entire setup depended on broken code to have side effects.
Re: [4.0.0] Where's the "Ouch" face?
Posted: Fri Aug 09, 2019 1:59 am
by Graf Zahl
Fixed. This needed a little bit of contortions to ensure that the health values being compared are properly synchronized. For that they must both be set in the same function.
Re: [4.0.0] Where's the "Ouch" face?
Posted: Fri Aug 09, 2019 2:01 am
by Player701
Yay! Thank you very much Graf
