VM Abort when using armor steal function in A_CustomPunch

[Ryuhi]

In the 3.7.x versions of GZdoom, I've been running into an issue when using a custom armor type in the A_Custompunch's lifesteal function (while using the correct flag, obviously.)

the abort message for my instance is:

Code: Select all

VM execution aborted: tried to read from address zero. 
Called from StateProvider.A_CustomPunch at gzdoom.pk3:zscript/inventory/stateprovider.txt, line 301 
Called from BrutalMeleeStaff.StateFunction.102 at test2.zip:decorate.meleestaff, line 123 //this is the line with the custompunch 
Called from PSprite.Tick at gzdoom.pk3:zscript/shared/player.txt, line 2265 
Called from PlayerPawn.TickPSprites at gzdoom.pk3:zscript/shared/player.txt, line 429 
Called from PlayerPawn.PlayerThink at gzdoom.pk3:zscript/shared/player.txt, line 1449 
Called from weapon state BrutalMeleeStaff.102 in BrutalMeleeStaff 
Called from PSprite.SetState [Native]

This would happen with every custom armor type I tested that inherited from BasicArmorBonus. However, once I switched an armor types inheritance to ArmorBonus, it would work normally. Since this is different from the previous versions, and ArmorBonus is listed on the wiki as the doom specific class, it would appear this is a bug.

[Graf Zahl]

This has already been fixed for the next version:

viewtopic.php?p=1088440#p1088440

[Ryuhi]

oh cool, I must have missed that topic. Thanks!