Page 1 of 1

Map loads twice when using +map command line param

Posted: Thu Jan 17, 2019 1:38 am
by gramps
When I run gzdoom like this:

Code: Select all

./gzdoom.exe -iwad wads/DOOM2.WAD +map map01 -stdout
The level loads twice in a row (notice "map01 - entryway" prints twice).

The second level load is visible if the the level happens to look different the second time around -- that is, you're already in place at the spawn point, seeing the first iteration of the map, when it loads again.

There might be a very fatal error associated with this in some cases.

Tested in 32bit DRD nightly build from last night.

Re: Map loads twice when using +map command line param

Posted: Thu Jan 17, 2019 7:27 am
by Rachael
gramps wrote:Tested in 32bit DRD nightly build from last night.
Please always include the build number, statements like this mean absolutely nothing when someone's unable to tackle the bug right away.

Re: Map loads twice when using +map command line param

Posted: Thu Jan 17, 2019 3:24 pm
by gramps
The filename was gzdoom-g3.8pre-226-ga92090690.7z ... I guess 226 is the build number, and the last part is the commit hash?

Felt pretty sure this would be related to level de-globalization and would be resolved one way or another by the time that's done with, but left it here just in case.

Re: Map loads twice when using +map command line param

Posted: Thu Jan 17, 2019 3:31 pm
by Enjay
I'm finding it easy to spot using g3.8pre-228-g3df112a7b and a map that plays a short sound via ACS as soon as the map starts. When using +map on the command line, I hear the sound twice.

Re: Map loads twice when using +map command line param

Posted: Thu Jan 17, 2019 3:35 pm
by Rachael
gramps wrote:The filename was gzdoom-g3.8pre-226-ga92090690.7z ... I guess 226 is the build number, and the last part is the commit hash?
The file name is perfect... and by build number I did mean hash as well, the whole thing is fine though, keep doing that, that's perfect. :)

Re: Map loads twice when using +map command line param

Posted: Fri Jan 18, 2019 5:03 am
by _mental_
Can be fixed like this. I want to be sure that the change fits well with level refactoring.

Re: Map loads twice when using +map command line param

Posted: Fri Jan 18, 2019 5:19 am
by Graf Zahl
Sadly not. When all is done, each level will have its own list of thinkers, so that commit will undo a lot of my preparation. The problem comes from the feature being incomplete. Static thinkers like the CCMD execution helpers need to be run outside the level's context in a global list, but I haven't gotten to that part yet. I hope do do it over the weekend.