[Fixed] Fake Contrast nullifying Lightspot around player sometimes

[Sinael]

I am not sure if this is a bug or just another weird Doom behaviour, but there should be at least an option to fix this IMO.
In "Software" and "Doom" sector lightmodes Player has a bright spot around them that raises the brightness of the surroundings to certain minimum that allows player to at least barely see nearby walls even in complete darkness.
However under some circumstances the fake contrast effect makes the wall lighting to go beyond black, that the aforementioned lightspot does not brighten it up (even if it brightens up surrounding walls that are in exact same 0 brightness sector). It rarely occures, but when it does - it sticks out like a sore thumb. Ocured plenty of times in Hellbound map set. Examples below are from E1M8 of DTWID.wad

With Fake Contrast


No Fake Contrast


Map spot

[Graf Zahl]

Do you have ambient occlusion enabled? The images look like you have.
If yes, how does it look without?

[Sinael]

Makes no positive difference at all, if anything makes it stick out even more.

[_mental_]

This happens with other sector light mode as well. Walls become pure black when calculated fake contrast value is equal to sector light level except the sign.
In other words, it happens when sum of a value assigned here and sector light level is zero.

By default, all horizontal walls of sectors with light level equal to 16 are affected. The initial value of WallHorizLight is -16.
Probably, there can be other ways to trigger this issue, but this one was obvious.