[3.7.x]EventHandler registering bug

[Major Cooke]

Load the following files from first to last:

1. test.pk3
2. test2.pk3
3. test3.pk3

Then type into console (doesn't matter what the message is, so long as it provokes NetworkProcess):

Code: Select all

netevent t

You will notice how Handler2 does not show up.

The handler orders are:

• Handler1: 9
• Handler2: 7
• Handler3: 11
• Handler4: 6

Now, if these are all together in one single PK3, all four of them are registered. However, when they're apart, this bug surfaces.

[_mental_]

The fix involves linked lists and garbage collection, so I decided to make this PR.

[Graf Zahl]

linked lists and garbage collection[/url].

Two things that constantly seem to be at odds with each other - the main reason why I avoid using linked lists with objects in new code.
The PR looks ok but I'll wait for someone to confirm that it works.

[Major Cooke]

I did some more testing with those three samples, and then I tested it in my mod series where the bug originally happened. Mental's solution fixes the issue entirely.