[Fixed] [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby YukesVonFaust » Tue Jan 08, 2019 8:48 pm

In the newest GZDoom and its devbuilds, the MSX/MSX2 KSS files no longer work and/or play anymore. it plays/works fine in 2.2.0, 3.2.4, and older builds, but not in 3.6.0, 3.7.1, and the latest devbuilds.
User avatar
YukesVonFaust
Kicking Asses and Taking Names
 
Joined: 09 Feb 2015
Location: in your area, where else
Discord: Yukes von Faust#9009
Operating System: Windows Vista/7 64-bit

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby Graf Zahl » Wed Jan 09, 2019 2:13 am

This sounds like a problem with the new GME version. So short of reverting this update I doubt something can be done.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby _mental_ » Wed Jan 09, 2019 2:43 am

GME was updated after 3.6 while according to the OP this version is affected as well.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby Graf Zahl » Wed Jan 09, 2019 2:46 am

Then I have no idea. I have never touched this code.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby _mental_ » Wed Jan 09, 2019 4:22 am

I downloaded a few KSS files and they are all silent in 2.2.0 and 3.2.4 both. Did it ever work?
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby YukesVonFaust » Wed Jan 09, 2019 4:39 am

_mental_ wrote:I downloaded a few KSS files and they are all silent in 2.2.0 and 3.2.4 both. Did it ever work?

try downloading the metal gear 2 solid snake kss file somewhere, and put :153 at the end, no spaces.

see if it works.
User avatar
YukesVonFaust
Kicking Asses and Taking Names
 
Joined: 09 Feb 2015
Location: in your area, where else
Discord: Yukes von Faust#9009
Operating System: Windows Vista/7 64-bit

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby _mental_ » Wed Jan 09, 2019 4:59 am

I see, my problem was in missing track numbers.

Well, this is GME update indeed. It works in 3.6 by the way.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby _mental_ » Wed Jan 09, 2019 6:15 am

This can be fixed by reverted Kss_Cpu.cpp to previous version and fixing type definitions to make it compile.
Let me if you want to have this change instead of reverting a whole update.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby YukesVonFaust » Wed Jan 09, 2019 6:31 am

_mental_ wrote:This can be fixed by reverted Kss_Cpu.cpp to previous version and fixing type definitions to make it compile.
Let me if you want to have this change instead of reverting a whole update.

yes, this change is enough.
User avatar
YukesVonFaust
Kicking Asses and Taking Names
 
Joined: 09 Feb 2015
Location: in your area, where else
Discord: Yukes von Faust#9009
Operating System: Windows Vista/7 64-bit

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby _mental_ » Wed Jan 09, 2019 6:34 am

YukesVonFaust wrote:
_mental_ wrote:This can be fixed by reverted Kss_Cpu.cpp to previous version and fixing type definitions to make it compile.
Let me if you want to have this change instead of reverting a whole update.

yes, this change is enough.

My message was addressed to Graf ;)
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby Graf Zahl » Wed Jan 09, 2019 6:40 am

Considering the regressions the update brought I'm not sure if it shouldn't be reverted again.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Postby _mental_ » Sat Jan 19, 2019 8:49 am

Fixed in df6669b.
_mental_
 
 
 
Joined: 07 Aug 2011


Return to Closed Bugs

Who is online

Users browsing this forum: Awario [RSS], yura_111 and 2 guests