Page 1 of 1

[Master] VM Abort when shooting a barrel in Harmony

PostPosted: Mon Jan 07, 2019 2:34 am
by Rachael


Harmony is available here

When shooting any of the "ExplosiveBarrel" types in Harmony, a VM abort is immediately caused. This happens even with +vm_jit 0.

Re: [Master] VM Abort when shooting a barrel in Harmony

PostPosted: Mon Jan 07, 2019 9:24 am
by _mental_
The issue was introduced in this commit. It affects 3.7 release too.

Re: [Master] VM Abort when shooting a barrel in Harmony

PostPosted: Mon Jan 07, 2019 9:39 am
by Graf Zahl
While the check is correct, it needs to be disabled if a state gets modified by Dehacked.

Re: [Master] VM Abort when shooting a barrel in Harmony

PostPosted: Sat Jan 12, 2019 3:53 am
by _mental_
Is it about disabling of this check if the state was modified by Dehacked? Or is it about a whole FState::CheckCallerType() function?

Re: [Master] VM Abort when shooting a barrel in Harmony

PostPosted: Sat Jan 12, 2019 4:46 am
by Graf Zahl
The other checks would be crash issues, but that particular one needs to be disable for Dehacked-modified states, because the non-Actor functions that can be set here would otherwise cause an abort. All Dehacked-usable functions should contain enough safety checks to not crash.

Re: [Master] VM Abort when shooting a barrel in Harmony

PostPosted: Sat Jan 12, 2019 5:22 am
by _mental_
Fixed in e353201.