[Fixed] [Master] VM Abort when shooting a barrel in Harmony

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[Master] VM Abort when shooting a barrel in Harmony

Postby Rachael » Mon Jan 07, 2019 2:34 am



Harmony is available here

When shooting any of the "ExplosiveBarrel" types in Harmony, a VM abort is immediately caused. This happens even with +vm_jit 0.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: [Master] VM Abort when shooting a barrel in Harmony

Postby _mental_ » Mon Jan 07, 2019 9:24 am

The issue was introduced in this commit. It affects 3.7 release too.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [Master] VM Abort when shooting a barrel in Harmony

Postby Graf Zahl » Mon Jan 07, 2019 9:39 am

While the check is correct, it needs to be disabled if a state gets modified by Dehacked.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [Master] VM Abort when shooting a barrel in Harmony

Postby _mental_ » Sat Jan 12, 2019 3:53 am

Is it about disabling of this check if the state was modified by Dehacked? Or is it about a whole FState::CheckCallerType() function?
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [Master] VM Abort when shooting a barrel in Harmony

Postby Graf Zahl » Sat Jan 12, 2019 4:46 am

The other checks would be crash issues, but that particular one needs to be disable for Dehacked-modified states, because the non-Actor functions that can be set here would otherwise cause an abort. All Dehacked-usable functions should contain enough safety checks to not crash.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [Master] VM Abort when shooting a barrel in Harmony

Postby _mental_ » Sat Jan 12, 2019 5:22 am

Fixed in e353201.
_mental_
 
 
 
Joined: 07 Aug 2011


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest