[Fixed] [bfbf7ff9c]Crash on start-up

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Re: [bfbf7ff9c]Crash on start-up

Postby Major Cooke » Sun Jan 06, 2019 11:57 am

Confirmed, I upgraded to VS2017 and ran CMake targeted for VS2017. It all works now.
User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846

Re: [bfbf7ff9c]Crash on start-up

Postby Blzut3 » Sun Jan 06, 2019 10:25 pm

Graf Zahl wrote:Or we may simply unsupport VC++ 2015 for being buggy.

This is more or less fine except right now the build machine is stuck with 2015. Hoping to resolve before the end of this month. So far Microsoft partners (since Microsoft's site points to contacting partners for it) are just ignoring my inquiries for volume licensing, so going to try just calling Microsoft soon.
Blzut3
Pronounced: B-l-zut
 
 
 
Joined: 24 Nov 2004

Re: [bfbf7ff9c]Crash on start-up

Postby Nash » Tue Jan 08, 2019 6:04 am

I just tried to build g73fd072d1 and I'm getting crash on startup too.

VS2017 Community 15.9.3
Yes, hard-deleted and re-generated build directory with CMake

Nothing, still crashes.
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: nVidia GTX or Quadro with Vulkan support

Re: [bfbf7ff9c]Crash on start-up

Postby _mental_ » Tue Jan 08, 2019 6:16 am

Are you sure it's the same crash? At the moment it crashes for me in S_UpdateSounds() with listenactor being null.
This is completely unrelated to a potential code generation bug in VS2015.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [bfbf7ff9c]Crash on start-up

Postby Nash » Tue Jan 08, 2019 6:22 am

Oh, I'm unsure about that. In that case I'll make a separate bug report with a crash log, to rule out bad compiler crash.
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: nVidia GTX or Quadro with Vulkan support

Re: [bfbf7ff9c]Crash on start-up

Postby Graf Zahl » Tue Jan 08, 2019 6:32 am

_mental_ wrote:Are you sure it's the same crash? At the moment it crashes for me in S_UpdateSounds() with listenactor being null.
This is completely unrelated to a potential code generation bug in VS2015.



I pushed a quick fix for this. Since the global timer needs to be moved out of the level struct anyway I'm not bothering with a complete fix for now.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Postby _mental_ » Tue Jan 08, 2019 7:43 am

I wanted to submit the same change, but it was not enough. Listener can be null here as well.
This one is a bit tricky. Am I right that if type is not SOURCE_None, listener and level should not be null?
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [bfbf7ff9c]Crash on start-up

Postby Graf Zahl » Tue Jan 08, 2019 8:57 am

Inside a level the listener cannot be null because the camera cannot be null, so if it is null, the sound cannot really be a level sound. Yes, you are correct about that assumption, such a sound should not really play when there is no listener.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Postby Collegia Titanica » Thu Jan 10, 2019 12:14 pm

Crashes for me too.
Collegia Titanica
 
Joined: 25 Jan 2018
Discord: 2834

Re: [bfbf7ff9c]Crash on start-up

Postby Graf Zahl » Thu Jan 10, 2019 12:46 pm

That post was rather pointless. We have already confirmed that this is a compiler bug in Visual C++ 2015, but do not know a workaround yet how to escape it.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Postby _mental_ » Fri Jan 18, 2019 3:50 am

In order to fix Windows x64 devbuilds we can disable optimization around turbo CVAR or rewrite this part using an intermediate volatile variable. Both solutions work for me.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [bfbf7ff9c]Crash on start-up

Postby Graf Zahl » Fri Jan 18, 2019 4:16 am

In that case I vote for disabling optimization for VS2015. That can later easily be removed when we really want to move on to a more modern C++ standard.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Previous

Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 2 guests