[bfbf7ff9c]Crash on start-up

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
Major Cooke
Posts: 8170
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: [bfbf7ff9c]Crash on start-up

Post by Major Cooke »

Confirmed, I upgraded to VS2017 and ran CMake targeted for VS2017. It all works now.
Blzut3
 
 
Posts: 3144
Joined: Wed Nov 24, 2004 12:59 pm
Graphics Processor: ATI/AMD with Vulkan/Metal Support
Contact:

Re: [bfbf7ff9c]Crash on start-up

Post by Blzut3 »

Graf Zahl wrote:Or we may simply unsupport VC++ 2015 for being buggy.
This is more or less fine except right now the build machine is stuck with 2015. Hoping to resolve before the end of this month. So far Microsoft partners (since Microsoft's site points to contacting partners for it) are just ignoring my inquiries for volume licensing, so going to try just calling Microsoft soon.
User avatar
Nash
 
 
Posts: 17434
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: [bfbf7ff9c]Crash on start-up

Post by Nash »

I just tried to build g73fd072d1 and I'm getting crash on startup too.

VS2017 Community 15.9.3
Yes, hard-deleted and re-generated build directory with CMake

Nothing, still crashes.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [bfbf7ff9c]Crash on start-up

Post by _mental_ »

Are you sure it's the same crash? At the moment it crashes for me in S_UpdateSounds() with listenactor being null.
This is completely unrelated to a potential code generation bug in VS2015.
User avatar
Nash
 
 
Posts: 17434
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: [bfbf7ff9c]Crash on start-up

Post by Nash »

Oh, I'm unsure about that. In that case I'll make a separate bug report with a crash log, to rule out bad compiler crash.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Post by Graf Zahl »

_mental_ wrote:Are you sure it's the same crash? At the moment it crashes for me in S_UpdateSounds() with listenactor being null.
This is completely unrelated to a potential code generation bug in VS2015.

I pushed a quick fix for this. Since the global timer needs to be moved out of the level struct anyway I'm not bothering with a complete fix for now.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [bfbf7ff9c]Crash on start-up

Post by _mental_ »

I wanted to submit the same change, but it was not enough. Listener can be null here as well.
This one is a bit tricky. Am I right that if type is not SOURCE_None, listener and level should not be null?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Post by Graf Zahl »

Inside a level the listener cannot be null because the camera cannot be null, so if it is null, the sound cannot really be a level sound. Yes, you are correct about that assumption, such a sound should not really play when there is no listener.
Collegia Titanica
Posts: 83
Joined: Thu Jan 25, 2018 1:37 pm

Re: [bfbf7ff9c]Crash on start-up

Post by Collegia Titanica »

Crashes for me too.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Post by Graf Zahl »

That post was rather pointless. We have already confirmed that this is a compiler bug in Visual C++ 2015, but do not know a workaround yet how to escape it.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [bfbf7ff9c]Crash on start-up

Post by _mental_ »

In order to fix Windows x64 devbuilds we can disable optimization around turbo CVAR or rewrite this part using an intermediate volatile variable. Both solutions work for me.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Post by Graf Zahl »

In that case I vote for disabling optimization for VS2015. That can later easily be removed when we really want to move on to a more modern C++ standard.
Post Reply

Return to “Closed Bugs [GZDoom]”