BringUpWeapon causes error on startup in devbuild

[DrPyspy]

When starting up the most recent devbuild (obtained from gzdoom-x64-g3.7pre-761-gcbb5f8a0d.7z) a mod that calls BringUpWeapon as player.BringUpWeapon() as opposed to player.mo.BringUpWeapon() will cause GZDoom to stop the startup process with an error that states "Script error, [...] Unknown function BringUpWeapon"

I have prepared an example pk3 that will properly run in 3.6.0, but will demonstrate the behavior above when ran in the specified devbuild: link here

A couple mods that do this and were released before the change are the 2.0 release of Doom Delta, and abort_m, although the linked commit has changed it from player.BringUpWeapon() to player.mo.BringUpWeapon()

[Rachael]

Seeing two mods break with this change, but seeing this happen in two mods, it's giving a clue that this problem may be a bit more widespread than I thought, initially. Thanks for the minimal example, by the way, DrPypsy.

[Marisa the Magician]

Thanks for this. I reverted my change.

[Graf Zahl]

Keep in mind that I deprecated the PlayerInfo variant from ZScript version 3.7 onwards.

[Rachael]

That's fine - I do think that what's important here is that the change didn't break mods that were previously compatible with 3.6.0. It was a concern that I had toward that change.

[Marisa the Magician]

Obviously I will change it back when 3.7 is out.