[g3.7pre-754-g888af3d68] Not crash on closing console

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
m8f
 
 
Posts: 1445
Joined: Fri Dec 29, 2017 4:15 am
Preferred Pronouns: He/Him
Operating System Version (Optional): Manjaro Linux
Location: Siberia (UTC+7)
Contact:

[g3.7pre-754-g888af3d68] Not crash on closing console

Post by m8f »

Steps to reproduce:
1. Launch GZDoom;
2. Open console by assigned toggleconsole key (grave accent - '`' - in my case).
Note 1: I'm using Dvorak Programming keyboard layout, and actually this key (without Shift) is '$'. For some reason, this key is recognized by GZDoom as grave accent. I wonder if this is related to the problem or not.
3. Close console by using the same key;
4. Crash.

Note 2: if the console is closed by Esc key, no crash happens.
Spoiler:
No crash log is generated.

Gnome version 3.22.2, Debian GNU/Linux 9 (stretch) 64-bit.
Last edited by m8f on Sun Dec 09, 2018 9:18 am, edited 1 time in total.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [g3.7pre-754-g888af3d68] Crash on closing console

Post by _mental_ »

First of all, this is not a crash. Try to run Release configuration and "mysteriously" it will go away.
Actually, this is indicated clearly in the log: Assertion 'string[0] != '$'' failed.

As for assertion itself, I think it's wrong. It fails when '$' is entered in console as the first character of a command. Same for menus, chat line, etc.
Most likely, the idea was to catch untranslated text lines. It seems to be impossible to detect such thing correctly there.

About Dvorak keyboard, I have no idea. Could be an issue with SDL or our SDL backend.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [g3.7pre-754-g888af3d68] Crash on closing console

Post by Graf Zahl »

Yes, that assert looks like a leftover from working on that code.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [g3.7pre-754-g888af3d68] Crash on closing console

Post by _mental_ »

OK, this assertion is removed in 40f77e5.

Unfortunately, I cannot check on Linux at the moment. macOS doesn't have Dvorak Programming keyboard input source.
User avatar
m8f
 
 
Posts: 1445
Joined: Fri Dec 29, 2017 4:15 am
Preferred Pronouns: He/Him
Operating System Version (Optional): Manjaro Linux
Location: Siberia (UTC+7)
Contact:

Re: [g3.7pre-754-g888af3d68] Not crash on closing console

Post by m8f »

The fix is confirmed. Thanks!
Post Reply

Return to “Closed Bugs [GZDoom]”