Something in map20 of Community Chest 4 is causing a crash.
Posted: Sat Nov 03, 2018 3:51 pm
by SiFi270
Here's the wad. Whenever I enter "map map20" into the console, I hear the start of the midi, but it crashes before showing a single frame of the map. Even after I moved my main configuration file so that GZDoom would create a completely new one, the problem persisted. I know this didn't happen in fairly recent versions of GZDoom because I used it to practice for the DWIronman League.
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Sat Nov 03, 2018 4:00 pm
by Enjay
I tried in the latest git build (Nov 02) and it worked just fine. Then, I went to the official 3.6.0 build and it did indeed crash. Then, I went back to the git build just to check and it crashed there too. Now it seems to be crashing reliably in either build every time.
[edit] For what it's worth (i.e. very little), it also seems to crash the last ever (I think) ZDoom git build, but not the last official ZDoom. [/edit]
[edit2] And just for further information, if I type "map map20" at the titlepic, the map starts without a crash. However, if I start a game (i.e. start map01) and then type it, I get a crash. [/edit2]
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Sat Nov 03, 2018 4:11 pm
by SiFi270
It seems to work with monsters disabled, so I guess it's one or more monsters that are causing the problem.
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Sat Nov 03, 2018 4:38 pm
by Graf Zahl
No, it's not a monster, it's a barrel. But it's not something obvious.
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Sat Nov 03, 2018 4:39 pm
by drfrag
Doesn't crash with ZDoom32 (based on DEC 03 2016, no ZScript). Crashes with 3.6.0_legacy.
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Sat Nov 03, 2018 4:56 pm
by Graf Zahl
That's gonna be a great round of bisecting the commit history...
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Sat Nov 03, 2018 5:28 pm
by drfrag
Just checked again and it crashes, but only happens if you start map20 after map01. So it's between 2.8.0 (FEB 03) and DEC 03.
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Sat Nov 03, 2018 5:55 pm
by drfrag
Crashes with 2.2.0 so between SEP 18 and DEC 03.
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Wed Nov 07, 2018 2:12 pm
by drfrag
And obviously that was wrong, it's between FEB 03 and SEP 18. Oops. Trying to bisect it now...
Re: Something in map20 of Community Chest 4 is causing a cra
Lemon update 2016-02-17 12:34:03 on branch parser-performance bad
Fixed: Player color slider size/position was wrong when using language strings. good
Fixed incorrect comparison in OS X console window bad
[fbbaae781b2d1ccded18d59908f7cd3b1417e4eb] Merge remote-tracking branch 'origin/master' good
- fixed: GetFloorCeilingZ used the actor's actual position, not the tmf.x, tmf.y for which information is supposed to be retrieved. good
Don't use fast math for gdtoa good
- fixed some language issues with the menu. good
- fixed a few incorrect uses of AngleTo function. good
- now that C++11 is allowed, these annoying 'narrowing conversion' warnings can finally be fixed... good
- implemented line portal transition. Not yet tested for arbitrary portals but for static ones it is working - including camera interpolation. bad
[451cac457bab13a72e37972e320ca580f6ddf15a] - added NULL pointer check in AActor::ClearInterpolation. bad
451cac457bab13a72e37972e320ca580f6ddf15a is the first bad commit
commit 451cac457bab13a72e37972e320ca580f6ddf15a
Author: Christoph Oelckers <c.oelckers@zdoom.fake>
Date: Fri Feb 26 18:05:58 2016 +0100
- added NULL pointer check in AActor::ClearInterpolation.
:040000 040000 272ab8c48cb469ce63c0cc52d5e0045799ffef00 1451062333eb19cc13249bc122572182a422f525 M src
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Thu Nov 08, 2018 2:38 am
by _mental_
Are you sure? Reverting that commit didn't fix anything to me. spechit still points to lines from previous map.
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Thu Nov 08, 2018 3:26 am
by Graf Zahl
What precisely happens? Are you saying that there is some code that uses spechit without clearing it first?
My guess is that it has to do with portals. Bisecting the code from back then is bound to fail because of all the branching going on. It probably picked on some merge and got confused. I have seen bisects of code that is this divergent to randomly jump between branches.
If you want to check the commit history for the place where this happened you'll have to do the bisecting manually, I fear.
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Thu Nov 08, 2018 4:10 am
by drfrag
No, somehow the executable was not replaced until i deleted it manually and the last commit was good.
It's the previous one:
Revision: 8d58d63b6054c7aad9e77e6df6102be43640d7e8
Author: Christoph Oelckers <coelckers@zdoom.fake>
Date: 27/02/2016 1:19:57
Message:
- implemented line portal transition. Not yet tested for arbitrary portals but for static ones it is working - including camera interpolation.
----
Modified: src/p_local.h
Modified: src/p_map.cpp
Modified: src/p_tick.cpp
Modified: src/r_utility.cpp
Modified: src/r_utility.h
Re: Something in map20 of Community Chest 4 is causing a cra
Posted: Thu Nov 08, 2018 4:30 am
by drfrag
I guess the executable was still running in the background after the crash. Here's the backtrace: