Pitch and Roll are not interpolated on model rendering

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

Pitch and Roll are not interpolated on model rendering

Post by Marisa the Magician »

I've been noticing this for a long time, and finally found the source of the problem. If one looks around line 128 of r_data/models/models.cpp, it appears that in actors with the INTERPOLATEANGLES flag, only the interpolated yaw is used, while pitch and roll will be steep (as can be seen on the parts above it where the USEACTORPITCH and USEACTORROLL flags are handled).

Edit: I'm working on a patch for this, will submit a PR once I test it.
Edit 2: PR here.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Pitch and Roll are not interpolated on model rendering

Post by Rachael »

I merged this, I also merged a couple other fairly small PR's that I was pretty sure would not fuck things up.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Pitch and Roll are not interpolated on model rendering

Post by Graf Zahl »

I reverted the RenderStyle stuff. I have several issues with that PR which is why I didn't do anything with it but unfortunately forgot about it.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Pitch and Roll are not interpolated on model rendering

Post by Rachael »

Oh. What were those issues, so that I do not repeat this mistake in the future? Nevermind, you put it in your commit message.
Post Reply

Return to “Closed Bugs [GZDoom]”