DIALOGUE defined in Gameinfo only works on maps named MAP**

[jewellds]

DIALOGUE lumps defined in GameInfo do not work unless you are in a map titled MAP01, MAP02, etc...
This is a problem as it won't work in Doom 1, Heretic, or any user made maps that aren't called "MAP**".
I have tested this in 3.4.1, and the latest dev build as of writing (gzdoom-g3.5pre-120-g1ef993832).

How to reproduce:

1. Download this simple test WAD. It contains 2 lumps - a DIALOGUE lump named "MYDIALOG" and a MAPINFO lump containing the following:

Code: Select all

GameInfo
{
   Dialogue = "MYDIALOG"
}

2. Load the WAD in Doom II, and start a new game. In the console, type "summonfriend scriptedmarine". Press use on the marine and get a simple dialogue message.

3. Load the WAD in Doom 1, or any map that doesn't use the scheme "MAP**". Summon the marine again, and press use. This time it will have no dialogue.

[_mental_]

This is intentional and it's always been like that. Most likely it was used only in Strife at first, the function is still named P_LoadStrifeConversations().
At the moment for non-MAPxx naming scheme a DIALOGUE lump accompanying every level in UDMF seems to be the only option.

[Graf Zahl]

The common lump should still be loaded, though. This is a relic from many, many years ago that just never got changed

[_mental_]

The common lump defined is in MAPINFO's GameInfo\Dialogue, right? Is SCRIPT00 considered common too?

[Graf Zahl]

Yes.

[_mental_]

Fixed in 4e2385e.

[jewellds]

I've given it a test and it now works in any map I throw at it.
Thanks for the quick fix!