Page 1 of 1

Truecolour crashes with Hacx 2.0, AoS, Strife

PostPosted: Sun Apr 15, 2018 7:01 pm
by GFD
Hope this isn't a duplicate, since it seems pretty obvious. Hacx 2.0 (not 1.2), Adventures of Square, and Strife all crash (tried to read address 0000000000000000) when using the truecolour carmack and truecolour softpoly renderers in-game. (This means Adventures of Square crashes on the title screen, as it has a titlemap.) OpenGL and both 8-bit renderers don't crash. Happens with 32-bit and 64-bit windows binaries. First dev build binary where this starts happening is gzdoom-x64-g3.4pre-197-g0affc119f.7z (ie. the first one with 2D refactor stuff).

I've attached a crash report where I started GZDoom with a fresh config, started a new game in Strife, and switched to the truecolour carmack renderer.

Re: Truecolour crashes with Hacx 2.0, AoS, Strife

PostPosted: Mon Apr 16, 2018 10:20 am
by Xaser
I'm curious: does Harmony crash too? A common thread here is that all the IWADs in question use the COLORMAP to define a fullbright color.

Bit of a stab in the dark, but it's the first thing that comes to mind regarding when thinking of "IWAD-specific" and "Render-related".

Re: Truecolour crashes with Hacx 2.0, AoS, Strife

PostPosted: Mon Apr 16, 2018 10:32 am
by GFD
Oh hey, Harmony does crash—I thought I had tested every supported IWAD, but apparently not. Good thinking!

Re: Truecolour crashes with Hacx 2.0, AoS, Strife

PostPosted: Tue Apr 17, 2018 2:01 am
by dpJudas
Pushed a fix for this.

Re: Truecolour crashes with Hacx 2.0, AoS, Strife

PostPosted: Tue Apr 17, 2018 9:47 am
by Xaser
Super-thanks! Good to know we didn't bork up anything too hard. :P