Radiation Suits check is ignored (or maybe not)

Miami_vice · Post by **Miami_vice** » Tue Jan 02, 2018 10:40 am

In my wad I have such action:

There is a player or there are players. There are lava sectors with TID=2. If player enters
lava sector and is without radiation suit he dies. Radiation suits are randomly spawned at dead monster
corpses before removing that corpse.(edited)
However sometimes monster is killed within lava sector and radion suit is spawned there. The player cannot go there.
I'm trying to create a script that spawns radion suits after checking whether this item is inside forbidden
sector with TID=2:

Code: Select all

if(Thingcount(T_IRONFEET, 0)-ThingCountSector(T_IRONFEET, 0, 2)<PlayerCount()) 
Thing_SpawnNofog(tag, T_IRONFEET, 0, 0);

If some radiation suits that are not in lava pools less than all players then spawn more.
But something is wrong. In the game it spawns more suits than players. I'm alone but I see more
suits in unrestricted areas.

Check what is wrong - my logics - or deep in the code, check for rad suits is omitted.

You might think that there are more monsters with the same tag is spawned. But I doubt it.
Spawn mechanism (aka algorithm) is this:

Spoiler:

Code: Select all

Script 74 (void)
{
 int easy_hard_monster_chance =0, d, xm, ym, p1, p2, p3, p4, tries;
 int cross = 0, tag;
 str m_class;
    while(getvariable(mbutton)) //Execute till button is pressed
    {
//------ Do msp_num number of times spawns of monsters at once ------------------------------------
        for(int i=0; i<getvariable(msp_num); i++)
        {
         tries = 1000; tag=0;
//------ Randomly picking up monster class --------------------------------------------------------
            easy_hard_monster_chance = random(1, 100);
            if(easy_hard_monster_chance <= 88) 
            {
                easy_hard_monster_chance = mo_index[random(0, 4)];
                m_class = monster_class[easy_hard_monster_chance];
                d=monster_size[0][easy_hard_monster_chance]/2;
            }
            else 
            {
                easy_hard_monster_chance = mo_index[random(5, 24)];
                m_class=monster_class[easy_hard_monster_chance];
                d=monster_size[0][easy_hard_monster_chance]/2;
            }
//---- Finding smallest available monster tag number to spawn among dead and alive current demons-- if corpse of a monster is removed then the value in the array is set to zero
            for(int k = 12001; k<getVariable(monster_tag); k++) {if(!alive_or_dead[0][k-12001]) {tag=k; break;}}
            if(!tag) 
            {
                if(getVariable(monster_tag)<=20000)
                {
                    tag = getVariable(monster_tag);
                    setVariable(monster_tag, getVariable(monster_tag)+1);
                }
            }
            if(tag)
            {
                do
                {
                cross = 0;
                //--------------------------------------------------------------------  
                    xm = random(-4576.0+(d*1.05), 5664.0-(d*1.05)); ym = random(-5664.0+(d*1.05), 4576.0-(d*1.05)); 
                    setVariable(sp_mx, xm); setVariable(sp_my, ym);
                //--------------------------------------------------------------------
                    for(int j=0; j<3; j++)
                    {
                        p1 = ComputeOutCode(1, j, d);
                        p2 = ComputeOutCode(2, j, d);
                        p3 = ComputeOutCode(3, j, d);
                        p4 = ComputeOutCode(4, j, d);
                        if(!p1 || !p2 || !p3 || !p4) {cross++; setvariable(sector_cross, cross); break;}
                    }
                    if(!cross)
                    {
                        if(!Spawn(m_class, xm, ym, -256.0, tag, random(0, 255)))
                        setVariable(actor_cross, 1); // if not spawned it means that code is trying  to spawn a monster in another monster place
                        else
                        {
                            alive_or_dead[0][tag-12001]=monster_size[1][easy_hard_monster_chance];
                            SetLineTexture(93+i, SIDE_FRONT, TEXTURE_MIDDLE, "LI_G1");
                            setVariable(monster_spawn, getvariable(monster_spawn)+1);
                        }
                    }
                    tries--;
                }while((cross || !thingcount(0, tag)) && tries);
            }
        }
//------ Showing recently spawned monster tag number ----------------------------------------------
     SetLineTexture(84, SIDE_FRONT, TEXTURE_MIDDLE, numpad[tag/10000%10]);
     SetLineTexture(85, SIDE_FRONT, TEXTURE_MIDDLE, numpad[tag/1000%10]);
     SetLineTexture(86, SIDE_FRONT, TEXTURE_MIDDLE, numpad[tag/100%10]);
     SetLineTexture(87, SIDE_FRONT, TEXTURE_MIDDLE, numpad[tag/10%10]);
     SetLineTexture(88, SIDE_FRONT, TEXTURE_MIDDLE, numpad[tag%10]);
     delay(mdelay[getvariable(m_freq_b)]);
    }
}

#define INSIDE 0
#define TOP 8
#define BOTTOM 4
#define RIGHT 2
#define LEFT 1

function int ComputeOutCode (int point_num, int j, int d)
{
 int px, py;
 int xm = getVariable(sp_mx);
 int ym = getVariable(sp_my);
 int code_out = INSIDE; // initialised as being inside of clip window
     d=d*1.0;
//-------------------------------------------------------------------     
     if(point_num == 1) {px=xm-d; py=ym+d;}
     else if(point_num == 2) {px=xm+d; py=ym-d;}
     else if(point_num == 3) {px=xm-d; py=ym-d;}
     else if(point_num == 4) {px=xm+d; py=ym+d;}
//-------------------------------------------------------------------     
     if(px>forbidden_sectors[j][1]) code_out |= RIGHT;
     else if(px<forbidden_sectors[j][0]) code_out |= LEFT;
     if(py>forbidden_sectors[j][2]) code_out |= TOP;
     else if(py<forbidden_sectors[j][3]) code_out |= BOTTOM;
 return code_out;
}

Post by **_mental_** » Tue Jan 02, 2018 10:56 am

Post runnable example please.

Miami_vice · Post by **Miami_vice** » Tue Jan 02, 2018 4:41 pm

Ok I'm adding the wad and a video how to play:

Demo how to use frequiencer. Green light is used to set corpses remove rate of outside monsters. Blue light is used to set the rate of corpses within base perimeter to be removed. Powerful scripts that react whenever how fasat and in whatever order you press buttons. As you can see there are still more than one Radiation suit. Why?

In scripts text lump there are 30th and 25th scripts that are rersponsible for corpses remove. There I've written under what circumstances to spawn T_IRONFEET. It should not spawn more than there are players. But it does. I don't know what is wrong.
Maybe deep inside ZDoom libraries there is omitted check for radiation suits. Maybe some devs would check and tell me what's wrong.

Runnable example (click to start download): Survivors_HQ for sharing2

P.S. If you will open the wad with doom builderII and start to test then there you will see that the button for sphere spawn doesn't work. I don't know why but it seems that in this way the program doesn't read data from BEHAVIOR but compiles from within text itself. If you will play the wad itself just with gzdoom then it should work. Besides, some buttons or lines still won't work properly. This is because I did a copy from original wad and removed many stuff that would take a lot of place.

Miami_vice · Post by **Miami_vice** » Fri Jan 05, 2018 5:50 pm

Ok folks.

I have found my mistake on my own.

ThingCount(T_Ironfeet, 0) works fine. I haven't checked ThingCountSector(T_IRONFEET, 0, 2) but I think it works ok too.

In scripts 25 and 30 I did debugging. I checked how many radiations suits are there for real using ACS command "Print". Code fragment looks like this:

Spoiler:

On the screen and in console I was able to see real actual data like:

Spoiler:
----------------------------------------------------------------
all rad suits: 0 suits in lava: 0 players: 1
----------------------------------------------------------------
all rad suits: 1 suits in lava: 0 players: 1
Radiation Suit spawn cancelled
----------------------------------------------------------------
all rad suits: 2 suits in lava: 0 players: 1
Radiation Suit spawn cancelled
----------------------------------------------------------------//I took one here during gameplay
all rad suits: 2 suits in lava: 0 players: 1
Radiation Suit spawn cancelled
----------------------------------------------------------------
all rad suits: 3 suits in lava: 0 players: 1
Radiation Suit spawn cancelled
---------------------------------------------------------------

It's clear that somewhere else this was spawning.

Actually it was 1 line above:

Code: Select all

else if(item_chance>193 && item_chance<200+1) Thing_SpawnNofog(tag, powerup[random(0, 10)], 0, 0);

And "powerup" array is defined at the beginning having "T_IRONFEET" inside as a member:

Spoiler:

I have removed that member from the array and changed indexes at all checking loops. Now everything is ok.

Please forgive me for your time waste.

P.S. I have added one really useful actors check right after successful spawn at script 74:

Spoiler:

It really works and checks whether more than one actors with the same tag has spawn at once.
And it never shows that in the way it is made. I have to specifically do some extra loop to spawn more at once.
Only then text is printed on the screen specifying how many and what class spawned. And tids.

That's all.

You can remove this post from "Bugs" section.

ZDoom