g0667f2e pickup model rotation isn't interpolated

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Nash
 
 
Posts: 17439
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

g0667f2e pickup model rotation isn't interpolated

Post by Nash »

It seems that the models are turning at 35 Hz. Tested with Enjay's GeneTech

[EDIT for clarity] I meant the rotating pickup items.
Last edited by Nash on Tue Nov 28, 2017 6:17 am, edited 1 time in total.
dpJudas
 
 
Posts: 3044
Joined: Sat May 28, 2016 1:01 pm

Re: g0667f2e model rotation isn't interpolated

Post by dpJudas »

Which of the renders did you test this in? For swr and softpoly it is expected behavior at the moment. If it is for the GL renderer it must be a bug.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49071
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: g0667f2e model rotation isn't interpolated

Post by Graf Zahl »

AFAIK turning is not interpolated by default because this was causing issue with mods depending on the angle being uninterpolated. This was once done but had to be reverted.
User avatar
Nash
 
 
Posts: 17439
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: g0667f2e model rotation isn't interpolated

Post by Nash »

I tested with the OpenGL renderer. Also, I should clarify that I'm talking about the rotating pickup items (again, GeneTech has plenty of those around).

I'm pretty sure those pickups used to rotate smoothly.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: g0667f2e pickup model rotation isn't interpolated

Post by _mental_ »

Works fine for me, with the exact Windows x64 devbuild and with the latest commit.
Rotation is very smooth regardless of GZDoom version: 3.2.1 or 0667f2e or the latest.

Please note model interpolation, gl_interpolate_model_frames CVAR, has no effect on rotating pickups.
Those models have only one frame and the engine itself changes their angles constantly.
Just in case try with default config, i.e. without .ini file.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49071
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: g0667f2e pickup model rotation isn't interpolated

Post by Graf Zahl »

There never was any interpolation here anyway, this had always been done in real time independently of the playsim.
User avatar
Rachael
Posts: 13571
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: g0667f2e pickup model rotation isn't interpolated

Post by Rachael »

I fixed an issue recently with yet more system timer overloads (this time, my own doing) that affected how models rotate. When the timer was being cast to double it was losing precision - all timer calculations are done with pure uint64_t's now and that may have solved this report.
Post Reply

Return to “Closed Bugs [GZDoom]”