[3.2] Custom IWADs not launchable via -iwad
Moderator: GZDoom Developers
Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Re: [3.2] Custom IWADs not launchable via -iwad
Fixed in b36fc82.
-
- Posts: 800
- Joined: Thu Apr 25, 2013 12:21 pm
- Preferred Pronouns: They/Them
- Operating System Version (Optional): Windows 11 for the Motorola Powerstack II
- Graphics Processor: nVidia with Vulkan support
- Location: The Corn Fields
- Contact:
Re: [3.2] Custom IWADs not launchable via -iwad
now all ipk3s are duplicated. Was that intentional?
Re: [3.2] Custom IWADs not launchable via -iwad
Yes, this is a known side effect of this change.
EDIT: To clarify, this commit doesn’t add duplicated entries for custom IWADs but removes elimination of entries for custom IWADs with the same name.
EDIT: To clarify, this commit doesn’t add duplicated entries for custom IWADs but removes elimination of entries for custom IWADs with the same name.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49056
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [3.2] Custom IWADs not launchable via -iwad
It SHOULD eliminate duplicates with the same full path, though, in case two directories in the search path point to the same directory.
Re: [3.2] Custom IWADs not launchable via -iwad
The case with multiple references to the same IWAD isn't handled indeed. Before the given commit duplicates were detected by their names only.
Full paths are not stored in the corresponding IWADs list at the moment. I'll try to fix it without significant changes.
Full paths are not stored in the corresponding IWADs list at the moment. I'll try to fix it without significant changes.
Re: [3.2] Custom IWADs not launchable via -iwad
Made duplicates removal consistent for all IWADs in c70f9cf.
The idea with usage of full path for duplicates check is nice. It requires a bit more effort though.
Lack of cross-platform path resolution and comparison is the main problem here.
Also, the detection should be implemented for all IWADs replacing existing name-based system.
The idea with usage of full path for duplicates check is nice. It requires a bit more effort though.
Lack of cross-platform path resolution and comparison is the main problem here.
Also, the detection should be implemented for all IWADs replacing existing name-based system.