[Fixed] Git commit broke build

Bugs that have been investigated and resolved somehow.

Moderators: Developers, ZDoom.org Team

Git commit broke build

Postby Phyllis Hirringhood » Sat Sep 16, 2017 3:41 pm

Hello.

This commit https://github.com/coelckers/gzdoom/com ... 1d7a118044 unfortunately broke build on BSD (e.g. because of wordexp), was the previous feature wrong ?

Thanks for the good work otherwise.
Kindest regards.
Phyllis Hirringhood
 

Re: Git commit broke build

Postby Chris » Sat Sep 16, 2017 11:21 pm

Phyllis Hirringhood wrote:This commit https://github.com/coelckers/gzdoom/com ... 1d7a118044 unfortunately broke build on BSD (e.g. because of wordexp), was the previous feature wrong ?

Prior to that patch, "quoted arguments" weren't honored. Unlike the Windows build they would get treated as two separate arguments, '"quoted' and 'arguments"', which breaks anything that needs a space (for example if you wanted to set timidity_extargs='-c "/path/to/soundfonts/my soundfont.cfg"').

Does BSD not have wordexp? Both it and glob (which has been used to find the executable) are listed as being POSIX.1-2001, POSIX.1-2008.
User avatar
Chris
 
Joined: 17 Jul 2003

Re: Git commit broke build

Postby Phyllis Hirringhood » Sun Sep 17, 2017 1:18 am

Not all unfortunately (wordexp is considered harmful and buggy to be worth implemented for some), ok I understand the reasoning a bit better though.
Phyllis Hirringhood
 

Re: Git commit broke build

Postby _mental_ » Wed Nov 01, 2017 7:53 am

I believe this was fixed in b871b18.
_mental_
 
 
 
Joined: 07 Aug 2011


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest