Class ZBell's Activate looks odd

[Fishytza]

Not a really a bug, just something that bothers me. No clue if it's intentional.
https://github.com/coelckers/gzdoom/blo ... s.txt#L883

Code: Select all

	override void Activate (Actor activator)
	{
		if (health > 0) A_Die();
		{
			DamageMobj (activator, activator, 10, 'Melee', DMG_THRUSTLESS); // 'ring' the bell
		}
   }

Why is DamageMobj there if A_Die is already used?

[Nash]

And why is that part enclosed in an additional pair of {}'s? Is that some programming technique I'm unaware of?

[_mental_]

Before scriptification the related code was the following:

Code: Select all

void AZBell::Activate (AActor *activator)
{
	if (health > 0)
	{
		P_DamageMobj (this, activator, activator, 10, NAME_Melee, DMG_THRUSTLESS); // 'ring' the bell
	}
}

Most likely A_Die(); part shouldn't be there.

[Graf Zahl]

How did that get there? Looks like some accidental Copy/Paste

[_mental_]

Fixed in 4101e9b.