Example wad with more than 4000 chars on a single comment.
Gzdoom builder can load and save that file but gzdoom/nodebuilder doesn't like to read that string.
Gzdoom Nodebuilder fail to parse huge comments.
Moderator: GZDoom Developers
Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Gzdoom Nodebuilder fail to parse huge comments.
- Attachments
-
nodebuilderFail.wad- (4.88 KiB) Downloaded 21 times
Re: Gzdoom Nodebuilder fail to parse huge comments.
What's the error you got? Because I'm getting 'No player 1 start' which means that map was loaded fine.
Re: Gzdoom Nodebuilder fail to parse huge comments.
This is what happens when I triy to save the map on gzdoom builder BF.
ZZYZX said it was a bug on Gzdoom NodeBuilder so I posted an example wad here.
Re: Gzdoom Nodebuilder fail to parse huge comments.
Topic's title is completely misleading.
Report sounds like a bug in GZDoom's embedded node builder but it's about an issue of ZDBSP in fact.
The string length limit is hardcoded indeed. Does someone have write access to this repository?
Report sounds like a bug in GZDoom's embedded node builder but it's about an issue of ZDBSP in fact.
The string length limit is hardcoded indeed. Does someone have write access to this repository?
-
Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49066
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: Gzdoom Nodebuilder fail to parse huge comments.
It's only in ZDBSP which uses an older version of the parser where the parse buffer is a static array. I can extend it but not unlimit it.
Re: Gzdoom Nodebuilder fail to parse huge comments.
if map comments aren't used by zdoom, couldn't the parser just ignore what's inside the string and just jump at the end of the ' " ' looking for a ';' symbol?
-
Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49066
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: Gzdoom Nodebuilder fail to parse huge comments.
This wasn't a bug in GZDoom. Its parser is well capable of handling long strings.
But the string buffer in ZDBSP was hardcoded to 4096 bytes, which I just expanded to 40960.
I also had to make a clone of its repo because I got no write access to Randi's.
But the string buffer in ZDBSP was hardcoded to 4096 bytes, which I just expanded to 40960.
I also had to make a clone of its repo because I got no write access to Randi's.
