[3.1.0] Crash when action function relies on default vector2

[Matt]

Also tried on 2ff492d.

To replicate, give this and fire:

Code: Select all

class badpistol:pistol{
	action void a_crashthis(vector2 crashing=(0,0)){
		A_Log("This will not appear");
		crashing+=vel.xy;
	}
	states{
	fire:
		PISG A 0 a_crashthis();
		goto super::fire;
	}
}

[_mental_]

When at least one vector2 or vector3 parameter with default value is present all defaults are ignored including implicit arguments for action functions.
I think that this line needs to be moved here. Although all code generation stuff is like a minefield to me and I need Graf's approval of this.

[Graf Zahl]

I think you are correct. The vector code here was added later, after the rest was already working.

[_mental_]

OK, fixed in eda55b2.