[Fixed] VM abort: A_SkelFist

[Major Cooke]

https://puu.sh/wc4Hg/22e6206a5b.png

It appears that change with the self check is still causing some issues.

[Graf Zahl]

Crap. The check is ok. What is not ok is that the previous call to target.DamageMobj can result in target becoming destroyed. The added check only revealed a much deeper and more serious logical error: It is absolutely unacceptable that damaging an object can result in an actor becoming immediately invalid, there needs to be a short delay so that subsequent operations on the killed actor still work.

While I cannot prevent this I have to issue a warning here: DO NOT USE 0-LENGTH DEATH STATES! They may cause problems in places you never expect if you are not extremely careful with checking if a DamageMobj call resulted in a kill. Always let it end in a waiting state. A simple 'goto null' instead of 'stop' is enough.

[Major Cooke]

All monsters in D4D have a 1 tic delay before their disappearance. You can check their xdeaths yourself if you want.

Code: Select all • Expand view

XDeathNoDrops:   
      TNT1 A 1
      {
         bThruActors = true;
         XDeathGush();
         D4DropItems();
         D4DropCash(CashMultiplier,CashDropper); //"ArachnoCashGiver");
         A_KillMaster("Massacre",KILS_FOILINVUL,null,"D4DSpawner");
         A_NoBlocking();   //just in case
         
         if (RuneChance(RuneChance_Arach))
         {   A_SpawnItemEx("ArachnotronRune",0,0,0,0,0,0,0,SXF_NOCHECKPOSITION); }
      }
      
      Stop;

So that's not the issue with D4D's monsters.

[Graf Zahl]

The error as described can only happen if DamageMobj destroys the target.

[Major Cooke]

Alright, but is my xdeaths otherwise acceptable?

[Graf Zahl]

Hard to tell, it calls lots of functions. You always have to be aware that they all get executed upon the 'SetState('Death') call inside DamageMobj so any of them may pull away the rug under the calling function.

[Gez]

Better put another TNT1 A 1 state in between.

(Kind of funny that "XDeathNoDrops" calls two Drop functions.)

[Major Cooke]

Hard to tell, it calls lots of functions. You always have to be aware that they all get executed upon the 'SetState('Death') call inside DamageMobj so any of them may pull away the rug under the calling function.

(Kind of funny that "XDeathNoDrops" calls two Drop functions.)

Most of those will be going away in the next update as I move the entirety of the pinata drops and cash giving to the event handler. This will allow non-D4D monsters to participate without needing replacements.

Those drop functions just mean "drop whatever you've accumulated" which the accumulation is performed before that state itself.

Code: Select all • Expand view

XDeath:
      "####" "#" 0  //loot drop
      {
         D4SetupLoot(true);
      }
      Goto XDeathNoDrops;