Page 1 of 1

ACS string table corruption

PostPosted: Sun Apr 30, 2017 7:31 pm
by Marrub
Summary 0000590
ACS string table corruption

Description
Same as issue 0000441 but, apparently, it's not save games causing this. Strings are just getting shuffled around in the string table, for some reason.

Additional Information
The attached save file uses doom2.wad and http://mab.greyserv.net/f/Lithium_1_4.pk7

Files
save30.zds

Re: 0000590: ACS string table corruption

PostPosted: Sun Apr 30, 2017 7:32 pm
by Marrub
Forgot to add, the save is running 2.4.0. (Though that could be determined by just looking inside the file.)
You can reproduce the issue by grabbing the plasma rifle in front of the player, but there's also corrupted strings in the log tab in the menu.

Re: 0000590: ACS string table corruption

PostPosted: Sun Apr 30, 2017 7:32 pm
by Graf Zahl
Sorry, but this is pretty much undebuggable.
The biggest roadblock are those ACS binaries which I cannot decompile or disassemble to rule out bad code generation as a culprit. To use dynamic strings from ACS libraries they need to follow very strict procedures of how to deal with strings. So far every time someone reported string corruption it was caused by badly generated byte code.

I need something smaller and more contained where I am capable of seeing what the scripts are actually doing. This is 1.8 MB of ACS binary code, all of which may indirectly be responsible for the problems.

Re: ACS string table corruption

PostPosted: Mon Nov 27, 2017 2:19 pm
by wildweasel
I'd like to amend this report by saying that FInal Doomer Plus (found at https://forum.zdoom.org/viewtopic.php?f=43&t=55061) also exhibits this glitch; weapon descriptions (invoked by holding Reload) will sometimes change into a letter A. I'd managed to trigger this with the Plutonia machine gun, but don't have a save file handy ([edit]: for what it's worth, though, it may have exhibited by use of autosaves).

Re: ACS string table corruption

PostPosted: Mon Nov 27, 2017 3:47 pm
by Marrub
Yeah, a lot of people are getting this bug, and the code is maybe 60 lines of vanilla ACS... That's kind of worrying.

Re: ACS string table corruption

PostPosted: Sun Nov 17, 2019 7:32 am
by phantombeta
Wasn't this one fixed?

Re: ACS string table corruption

PostPosted: Sun Nov 17, 2019 7:58 am
by Graf Zahl
It probably is - then again - maybe not. Who knows if it was the same thing, like I said this was undebuggable.

Re: ACS string table corruption

PostPosted: Sun Nov 17, 2019 8:09 am
by phantombeta
Graf Zahl wrote:It probably is - then again - maybe not. Who knows if it was the same thing, like I said this was undebuggable.

It was most definitely the exact same bug Final Doomer had, there's literally zero doubt about that.

Re: ACS string table corruption

PostPosted: Sun Nov 17, 2019 8:11 am
by _mental_
Most likely, it was this bug. I don't remember that something like this was reported after the given change.