[Fixed] Strife Dialogue NPCs Network issue

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Strife Dialogue NPCs Network issue

Postby Tapwave » Fri Sep 30, 2016 9:49 am

Too long for the title, but.
If you speak to a DIALOGUE-bound NPC in a netgame, and exit the dialogue box by clicking the dialogue exit choice rather than pressing esc, this NPC cannot be interacted with by anyone else but you.
User avatar
Tapwave
On the GREEN!
 
Joined: 20 Aug 2011
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Strife Dialogue NPCs Network issue

Postby Nash » Sun Feb 21, 2021 10:36 am

An attempted fix, 5 years later. :D https://github.com/coelckers/gzdoom/pull/1312/files
User avatar
Nash
Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: Strife Dialogue NPCs Network issue

Postby Graf Zahl » Sun Feb 21, 2021 11:06 am

Check line 691. It seems you missed one

player->ConversationFaceTalker = false;

that's no longer needed.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Strife Dialogue NPCs Network issue

Postby Nash » Sun Feb 21, 2021 11:16 am

Woops. Fixed and force-pushed.
User avatar
Nash
Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: Strife Dialogue NPCs Network issue

Postby Rachael » Mon Feb 22, 2021 6:07 am

Is there anything else that would make merging this right now bad?
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Strife Dialogue NPCs Network issue

Postby Graf Zahl » Mon Feb 22, 2021 7:03 am

I don't think so.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Strife Dialogue NPCs Network issue

Postby Rachael » Mon Feb 22, 2021 7:13 am

Alright I'll test it later on today and then merge it if I don't get any problems with it.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Strife Dialogue NPCs Network issue

Postby Rachael » Tue Feb 23, 2021 11:45 am

User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests