[r4179] Fatal error on loading of KDiZD

[_mental_]

Starting from the given revision it's impossible to play Knee-Deep in ZDoom. Loading is stopped on the following error:

Code: Select all

Script error, "kdizd_11.pk3:decorate/decorations.txt" line 996:
SC_GetFloat: Bad numeric constant "0.4´".

As you may noticed there is an unexpected character with code 0xB4 in float constant. Before r4179 character type in the script parser was signed and everything was worked fine. In r4179 character type became unsigned introducing this issue.

I guess it can be fixed by adding some hack (or let's better call it work-around ) to FScanner::OpenFile() in order to replace the wrong character with zero. That is to check include filename, lump size, MD5 and an actual character with the fixed offset and then change it to '0'.

Is there a better way to solve such a compatibility problem?

[Enjay]

Is there a better way to solve such a compatibility problem?

I'd suggest that with most, if not all, of the people involved in KDiZD still being in the community, perhaps a fix to the project is a better option?

[Graf Zahl]

This can't be fixed without butchering the parser. It needs to fixed in the mod. Sorry.

BTW, I'd fix it myself but

a) I can't upload to /idgames because my ISP somehow blocks the server
b) It also needs to be updated on Tormentor's KDiZD homepage.

[Tormentor667]

a) I can't upload to /idgames because my ISP somehow blocks the server
b) It also needs to be updated on Tormentor's KDiZD homepage.

If you fix it and send me the new file (Dropbox or whatever), I can do both of this for you

[Graf Zahl]

The fixed version is already available on /idgames so you can get it from there.