[Fixed] [GZDoom] 544 tall skies still wrapping

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[GZDoom] 544 tall skies still wrapping

Postby Kate » Sat Apr 23, 2011 2:09 pm

Spoiler:

If a sky is exactly 544px tall it's big enough to fill in all of ZDoom's freelook space and lever wrap (Edit: and never wrap). However GZDoom still insists on making it wrap once, which makes it look like a mess.
User avatar
Kate
... in loving memory ...
 
Joined: 15 Jul 2003

Re: [GZDoom] 544 tall skies still wrapping

Postby ChronoSeth » Sat Apr 23, 2011 3:20 pm

I've noticed this too. AFAIK, the height of the texture is not taken into account at all, and the sky texture is always tiled downward once.
User avatar
ChronoSeth
You are totally unique... just like everyone else.
 
Joined: 05 Jul 2010
Location: British Columbia
Discord: Chronoseth#5597

Re: [GZDoom] 544 tall skies still wrapping

Postby randi » Thu Mar 15, 2012 7:44 pm

Closing because GZDoom has its own bugs forum. (And bumping so it might get noticed by somebody who might do something with it.)
User avatar
randi
Site Admin
 
Joined: 09 Jul 2003

Re: [GZDoom] 544 tall skies still wrapping

Postby Gez » Thu Mar 29, 2012 5:04 pm

Looking into gl_skydome.cpp, this appears to be by design. The RenderDome() function calls another function called RenderSkyHemisphere() twice, once for the upper hemisphere and the second time for the lower hemisphere.

So it's not so much that it wraps or tiles the texture, it's just that it draws it twice, independently of texture size.

I'm not going to change anything about how it works.
Gez
 
 
 
Joined: 06 Jul 2007

Re: [GZDoom] 544 tall skies still wrapping

Postby NeuralStunner » Thu Mar 29, 2012 5:15 pm

What about a new MapInfo key (GZDoom specific, ZDoom ignored) to enable single-image sky?
User avatar
NeuralStunner
Cuddly but Packin'
 
 
 
Joined: 21 Jul 2009
Location: Indiana, USA
Discord: NeuralStunner#1293

Re: [GZDoom] 544 tall skies still wrapping

Postby Gez » Thu Mar 29, 2012 5:22 pm

Unless Graf does it, it won't happen.
Gez
 
 
 
Joined: 06 Jul 2007

Re: [GZDoom] 544 tall skies still wrapping

Postby NeuralStunner » Thu Mar 29, 2012 5:23 pm

Would you recommend an official suggestion on yon GZDoom forum, then?
User avatar
NeuralStunner
Cuddly but Packin'
 
 
 
Joined: 21 Jul 2009
Location: Indiana, USA
Discord: NeuralStunner#1293

Re: [GZDoom] 544 tall skies still wrapping

Postby Gez » Thu Mar 29, 2012 5:40 pm

You can try.
Gez
 
 
 
Joined: 06 Jul 2007

Re: [GZDoom] 544 tall skies still wrapping

Postby Graf Zahl » Thu Mar 29, 2012 5:50 pm

Well, such tall skies were never considered when the function was written
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [GZDoom] 544 tall skies still wrapping

Postby printz » Sat Mar 31, 2012 1:23 am

What is the equivalent skybox for how GZDoom renders the skies natively? How large should that cylinder be, where is the camera placed? I know this post would be better for the drdteam forum, but I don't want to destroy the equivalent thread there.
User avatar
printz
BOW BEFORE ME!
 
Joined: 26 Oct 2006
Location: Bucharest, Romania

Re: [GZDoom] 544 tall skies still wrapping

Postby Gez » Sat Mar 31, 2012 1:43 am

It's a sphere, not a cylinder. It's made of triangles like a geodesic dome. The shape is a bit weird in that the upper hemisphere covers about everything, the lower hemisphere only plugs a tiny hole at the bottom (as shown on the OP's pic).
Gez
 
 
 
Joined: 06 Jul 2007

Re: [GZDoom] 544 tall skies still wrapping

Postby Graf Zahl » Sat Mar 31, 2012 7:52 am

Should be better now. I reworked the coordinate calculations for oversized skies (larger than 240 pixels. The old code wasn't meant to work for anything taller than 256 pixels.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [GZDoom] 544 tall skies still wrapping

Postby Gez » Sat Mar 31, 2012 10:44 am

Indeed, much better. I got a strange variant of halls of mirrors with r1332 and a 1024x1024 sky texture (it seemed like some triangles were HOMing, others not), now it looks normal.
Gez
 
 
 
Joined: 06 Jul 2007


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest