[Fixed] [after 2.4.1 - 2255] Crash: Invulnerability spheres

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[after 2.4.1 - 2255] Crash: Invulnerability spheres

Postby Edward-san » Sun Mar 28, 2010 5:16 pm

Ok here it is the problem: taking an invulnerability sphere when you're already in invulnerability state crashes the game immediately.
How to reproduce: just summon two invulnerabilitysphere and that's it.

CrashReport.zip
You do not have the required permissions to view the files attached to this post.
Edward-san
Mathematics is the language with which God has written the universe. (Galilei)
 
Joined: 17 Oct 2009

Re: [after 2.4.1 - 2255] Crash: Invulnerability spheres

Postby Deathlike2 » Sun Mar 28, 2010 5:22 pm

This can be easily reproduced in map28 of Doom2... in the main Spider Lord and company area.
Deathlike2
Lone Strife Nut
 
Joined: 03 Nov 2004

Re: [after 2.4.1 - 2255] Crash: Invulnerability spheres

Postby Gez » Sun Mar 28, 2010 5:34 pm

It calls EndEffect() when picked up and provokes a null pointer error as the second sphere has no owner yet when this happens, apparently. I've solved the issue by changing the relevant line to this:
Code: Select allExpand view
   if (colormap != NOFIXEDCOLORMAP && Owner && Owner->player && Owner->player->fixedcolormap == colormap)
Gez
 
 
 
Joined: 06 Jul 2007

Re: [after 2.4.1 - 2255] Crash: Invulnerability spheres

Postby Graf Zahl » Mon Mar 29, 2010 12:06 am

Grrr. Now I can do another GZDoom release...
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests