[Fixed] "Force respawn" and "Respawn protection" are not DM-only

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

"Force respawn" and "Respawn protection" are not DM-only

Postby Player701 » Sun Apr 14, 2019 3:43 am

The two deathmatch-only DMFlags, "Force respawn" and "Respawn protection", do not currently function as deathmatch-only despite being placed in the "Deathmatch settings" submenu. This is because the correct condition to test for when checking whether these flags are enabled should be "deathmatch || alwaysapplydmflags" instead of "multiplayer || alwaysapplydmflags". Multiplayer is always true for net games regardless of whether the current game is a deathmatch game, so the current logic is obviously flawed.

PR with the fix here.
User avatar
Player701
You are now breathing manually.
 
Joined: 13 May 2009
Location: Russian Federation
Discord: Player701#8214

Re: "Force respawn" and "Respawn protection" are not DM-only

Postby Rachael » Sun Apr 14, 2019 4:42 am

That is a pretty glaring oversight and I am not sure what the real intent there was. But it does not make any sense to have these in coop, anyway, so I merged it.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: "Force respawn" and "Respawn protection" are not DM-only

Postby Graf Zahl » Sun Apr 14, 2019 4:59 am

Behold the skeletons in ZDoom's closet. It's probably not the last.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: "Force respawn" and "Respawn protection" are not DM-only

Postby Matt » Sun Apr 14, 2019 8:10 pm

I don't see any reason why these should be made unusable for coop. (especially respawn protection on certain maps that can end up with a start that's badly overrun by monsters)
User avatar
Matt
Putting the XD into *xdeath since 2007
 
 
 
Joined: 04 Jan 2004
Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia

Re: "Force respawn" and "Respawn protection" are not DM-only

Postby Arctangent » Sun Apr 14, 2019 8:43 pm

Matt wrote:I don't see any reason why these should be made unusable for coop. (especially respawn protection on certain maps that can end up with a start that's badly overrun by monsters)

That's what alwaysapplydmflags is for, I imagine.
User avatar
Arctangent
squawky
 
Joined: 06 Nov 2014
Discord: SquawkyAtan#2371

Re: "Force respawn" and "Respawn protection" are not DM-only

Postby Rachael » Sun Apr 14, 2019 10:37 pm

Arctangent wrote:
Matt wrote:I don't see any reason why these should be made unusable for coop. (especially respawn protection on certain maps that can end up with a start that's badly overrun by monsters)

That's what alwaysapplydmflags is for, I imagine.

^ This ^
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest