No 'old and unsupported DeHackEd patch' error message

Post by **drfrag** » Tue Mar 20, 2018 12:59 pm

You won't get the old and unsupported DeHackEd patch error message with certain old patch versions. A guy has reported @doomworld a crash for ZDoom CL with a very old dehacked patch (2.0). In modern versions you'll get the not a DeHackEd patch file error message instead so it's a minor thing.
It's a bad condition introduced in the commit 'Added support for older versions of DeHackEd patches'.
These are the existing patch versions: v. 1.0, 1.2, 1.3, 2.0, v2.1, v2.2, v2.3, v2.4, v3.0, v3.1.
The fix is here so you can just copy-pasta. Tested with r2wolfd2.zip and ttp-rp.zip.

https://github.com/drfrag666/gzdoom/com ... 8e7489f0e1

Post by **_mental_** » Wed Mar 21, 2018 2:56 am

The condition I wrote for DeHackEd version is really weird indeed.
Although I think it would be better to explicitly check for supported versions which are either 2.3 or 3.0.
DeHackEd 2.3 and 2.4 save patches with 'v2.3' header text and 3.x with 'v3.0'.

Post by **drfrag** » Wed Mar 21, 2018 3:31 am

I didn't know that, i guess that's what you were trying to do. I don't think so, the old code didn't check explicitly for 3.0 and that would be more complicated. As long as the condition matches the existing versions it's fine. If i were you i'd just copy-pasta.

Post by **_mental_** » Wed Mar 21, 2018 5:09 am

Merged in 88bebae.

Found two related bugs while testing it

Post by **drfrag** » Wed Mar 21, 2018 11:19 am

Great, thanks! It's an official contribution then.

ZDoom