Like feature suggestions, but you've actually written code to make it happen. More likely to make it into the game than some random request in feature suggestions.
Moderator: GZDoom Developers
by m8f » Tue Nov 24, 2020 10:17 am
Pull requestThis CVAR controls if par time and suck time are displayed on intermission screen. True by default (original behavior).
This commit adds a new string to the menu, MISCMNU_WISHOWPARTIMES. In English it should be something like "Par time on summary screen".
Honestly, I'm not sure if this belongs to the engine at all. The engine is already oversaturated with options, but I found no way to mod around this barring replacing intermission screens.This is more a personal nitpick than a widely useful feature. The reason behind this option is that the par time on the screen says how you "should" play a level, and it is irrelevant for modded play.
Last edited by m8f on Wed Nov 25, 2020 9:39 am, edited 2 times in total.
-

m8f
- dreamer
-

-
- Joined: 29 Dec 2017
- Location: Siberia (UTC+7)
- Discord: m8f#0629
- Github ID: mmaulwurff
- Operating System: Debian-like Linux (Debian, Ubuntu, Kali, Mint, etc) 64-bit
by Rachael » Tue Nov 24, 2020 9:29 pm
m8f wrote:The reason behind this option is that the par time on the screen says how you "should" play a level, and it is irrelevant for modded play.
Not to bike-shed or anything on this, but wouldn't it make more sense to make this mod controlled rather than using a CVAR?
-

Rachael
- Webmaster
-
- Joined: 13 Jan 2004
- Discord: Rachael#3767
- Twitch ID: madamerachelle
- Github ID: madame-rachelle
- Operating System: Windows 10/8.1/8/201x 64-bit
- OS Test Version: No (Using Stable Public Version)
- Graphics Processor: nVidia with Vulkan support
by m8f » Wed Nov 25, 2020 6:41 am
Like, how? Exposing to script how the intermission info (wbstartstruct_t) is filled up? Or making LevelLocals.partime not readonly so mods can set it to 0?
It's currently possible to replace intermissions screen by mods, but that would mean basically duplicating code and won't be compatible with custom intermissions.
-

m8f
- dreamer
-

-
- Joined: 29 Dec 2017
- Location: Siberia (UTC+7)
- Discord: m8f#0629
- Github ID: mmaulwurff
- Operating System: Debian-like Linux (Debian, Ubuntu, Kali, Mint, etc) 64-bit
by Graf Zahl » Wed Nov 25, 2020 7:10 am
What do you need this for anyway? If it's for a mod, the proper way to add it would be a key in the gameinfo section of MAPINFO.
-

Graf Zahl
- Lead GZDoom+Raze Developer

-
- Joined: 19 Jul 2003
- Location: Germany
by Rachael » Wed Nov 25, 2020 7:16 am
m8f wrote:Like, how?
Doing what Graf suggested, mainly. It could just be set to not show par times, and the appropriate ammendments would be made to the stat screen as needed to accomodate this.
-

Rachael
- Webmaster
-
- Joined: 13 Jan 2004
- Discord: Rachael#3767
- Twitch ID: madamerachelle
- Github ID: madame-rachelle
- Operating System: Windows 10/8.1/8/201x 64-bit
- OS Test Version: No (Using Stable Public Version)
- Graphics Processor: nVidia with Vulkan support
by m8f » Wed Nov 25, 2020 9:38 am
Done, force-pushed to the PR. Now instead of a CVAR this adds "hidepartimes" MAPINFO/GameInfo property which makes intermission screens hide par time and suck time.
False by default.
Example mod's mapinfo.txt that disables par times looks like this:
- Code: Select all • Expand view
gameinfo
{
hidepartimes = true
}
(example mod is attached to the PR)
-

m8f
- dreamer
-

-
- Joined: 29 Dec 2017
- Location: Siberia (UTC+7)
- Discord: m8f#0629
- Github ID: mmaulwurff
- Operating System: Debian-like Linux (Debian, Ubuntu, Kali, Mint, etc) 64-bit
Return to Code Submissions
Who is online
Users browsing this forum: No registered users and 0 guests