Make various methods clearscope, and bump ZScript version

Moderator: GZDoom Developers

Post Reply
argv
Posts: 184
Joined: Tue Aug 30, 2016 4:47 pm

Make various methods clearscope, and bump ZScript version

Post by argv »

I've sent two PRs.

PR #532 makes several ZScript methods clearscope and (where applicable) const. Please see the PR for rationale.

PR #533 sets the ZScript version on master to 3.5.0. It was set to that in the 3.5.0 release commit, but was left at 3.4.0 on master.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Make various methods clearscope, and bump ZScript versio

Post by Graf Zahl »

For the clearscope thing I'll wait for feedback of someone working on the C/S branch. I cannot say if any of it may interfere with that.
User avatar
Rachael
Posts: 13531
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Make various methods clearscope, and bump ZScript versio

Post by Rachael »

I don't have a clear answer right now for that, so please bump this thread when the branch has matured a bit more. Right now we don't know exactly how client-side actors are going to be handled so without that it's difficult to say whether it's safe to move ahead with this or not.

(For reference the two clientside implementations being considered are static dummy actors that simply mimic their server counterparts in all available visual aspects, and the second idea was to spawn copies of the server representations and allow the client to execute these actors directly as a means of prediction)

Even if it is, it's a fairly certain bet that clearscoping these won't work as expected on the client side, but we'll have to climb that hill when we get there before we'll really know for sure.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Make various methods clearscope, and bump ZScript versio

Post by Graf Zahl »

So we have to be very careful with clearscoping stuff.
argv
Posts: 184
Joined: Tue Aug 30, 2016 4:47 pm

Re: Make various methods clearscope, and bump ZScript versio

Post by argv »

Okay.

Some of the methods I mentioned are, as far as I can tell, completely unaffected by playsim state (they're either pure or access static class information), namely deltaangle, absangle, AngleToVector, RotateVector, Normalize180, FindState, and GetDropItems. What if I send another PR that clearscopes only those? Would that be safe to merge now?

Good luck on the C/S branch, by the way. Modern, Zandronum-like networking with an up-to-date engine would be completely awesome. :biggrin:
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Make various methods clearscope, and bump ZScript versio

Post by Graf Zahl »

argv wrote:Okay.

Some of the methods I mentioned are, as far as I can tell, completely unaffected by playsim state (they're either pure or access static class information), namely deltaangle, absangle, AngleToVector, RotateVector, Normalize180, FindState, and GetDropItems. What if I send another PR that clearscopes only those? Would that be safe to merge now?

Good luck on the C/S branch, by the way. Modern, Zandronum-like networking with an up-to-date engine would be completely awesome. :biggrin:

If it is purely static, clearscope is safe. So yes, please do.
argv
Posts: 184
Joined: Tue Aug 30, 2016 4:47 pm

Re: Make various methods clearscope, and bump ZScript versio

Post by argv »

Done. #536 clearscopes only the static and meta methods.
Post Reply

Return to “Closed Feature Suggestions [GZDoom]”