[Added] DamageMobj DMG_NO_PAIN Flag

Moderator: Developers

DamageMobj DMG_NO_PAIN Flag

Postby Major Cooke » Tue Nov 07, 2017 11:04 am

Pull Request

Simplifies the desire to switch off pain effects entirely so entities don't have to waste time flipping a flag on and then turning it back off again, and could prove useful later if internal functions need them. Plus, I'm not sure if DamageMobj even has time to properly check if the thing is still painless when it starts.
User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846

Re: DamageMobj DMG_NO_PAIN Flag

Postby Rachael » Tue Nov 07, 2017 11:49 am

I submitted some change requests.

Also let's not begin a pull request barrage, again, please?
User avatar
Rachael
QZDoom + Webmaster
 
Joined: 13 Jan 2004

Re: DamageMobj DMG_NO_PAIN Flag

Postby Rachael » Tue Nov 07, 2017 11:56 am

This is going to need a lot of testing, because DamageMobj is a function that gets called quite a lot internally for lots of different reasons. The only way I can be confident in this code is if it's tested "in the wild", so I am going to go ahead and do a QZDoom merge of this and let it stay pending until some people have picked it up.
User avatar
Rachael
QZDoom + Webmaster
 
Joined: 13 Jan 2004

Re: DamageMobj DMG_NO_PAIN Flag

Postby Graf Zahl » Tue Nov 07, 2017 12:22 pm

I still regret accepting all the pain mess - this only makes it worse. :(
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: DamageMobj DMG_NO_PAIN Flag

Postby Major Cooke » Fri Nov 10, 2017 11:45 am

That's why I made this as simple as possible, because I can rely on making my own variant of pain chancing via the virtual override. I'm letting DamageMobj do its work on the inside without causing any pain just so I can get some numbers from damagefactor modifications and then getting the number immediately.

I have absolutely no intention of introducing a DMG_CAUSE_PAIN or DMG_ALLOW_PAIN flag at all.
User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846

Re: DamageMobj DMG_NO_PAIN Flag

Postby Major Cooke » Fri Sep 07, 2018 11:29 am

Close me. This was added.
User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest