Page 1 of 1

Regarding pull requests for ACS features

Posted: Mon Mar 31, 2014 7:58 am
by Graf Zahl
There have been several pull requests for ACS extensions recently, and they all share the same problem: They only contain the changes needed on ZDoom's side, but nothing on ACC's side.

Please note that I will not add any such request unless it is either accompanied by a corresponding request for the ACC repo or some info what to add - even if it's supposedly trivial and obvious there's still stuff that can be missed and render the submitted feature inoperable.

Re: Regarding pull requests for ACS features

Posted: Mon Mar 31, 2014 8:36 am
by Nightfall
Hm? My change doesn't need any changes to ACC since it's a change on how a parameter is interpreted.

Re: Regarding pull requests for ACS features

Posted: Mon Mar 31, 2014 10:46 am
by Graf Zahl
Ok, but please mention such a thing next time, just in case. I thought it required an extension to the function table.