Regarding pull requests for ACS features

Like feature suggestions, but you've actually written code to make it happen. More likely to make it into the game than some random request in feature suggestions.

Moderator: Developers

Forum rules
Please see Code submission guidelines

GZDoom Status:
Image Image

Link to Legacy Repo

QZDoom Status:
Image Image

Regarding pull requests for ACS features

Postby Graf Zahl » Mon Mar 31, 2014 8:58 am

There have been several pull requests for ACS extensions recently, and they all share the same problem: They only contain the changes needed on ZDoom's side, but nothing on ACC's side.

Please note that I will not add any such request unless it is either accompanied by a corresponding request for the ACC repo or some info what to add - even if it's supposedly trivial and obvious there's still stuff that can be missed and render the submitted feature inoperable.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Regarding pull requests for ACS features

Postby Nightfall » Mon Mar 31, 2014 9:36 am

Hm? My change doesn't need any changes to ACC since it's a change on how a parameter is interpreted.
User avatar
Nightfall
 
Joined: 06 Aug 2009
Location: Finland

Re: Regarding pull requests for ACS features

Postby Graf Zahl » Mon Mar 31, 2014 11:46 am

Ok, but please mention such a thing next time, just in case. I thought it required an extension to the function table.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Code Submissions

Who is online

Users browsing this forum: No registered users and 1 guest