[Fixed] Moving camera breaks titlemap menu

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Moving camera breaks titlemap menu

Postby gramps » Wed Jan 23, 2019 9:51 pm

The game menu disappears after a few seconds when using a titlemap and a Moving Camera.

Steps to reproduce:

- Set up a titlemap with a Moving Camera thing and path nodes for it.
- Set the player's view to the camera, using Thing_Activate(tid); ChangeCamera(tid, 1, 0); in an ACS script.
- Run the game, open the menu right away, wait a few seconds. Menu disappears. Resizing window will replace the menu.

After the menu disappears (or if enough time passes before you open it), hitting a key to open/close it will still make the noise, but the menu won't display.

Commenting out either Thing_Activate or ChangeCamera, the menu works fine.

Tested in 3.8 pre-238.

Will create a test map when I have more time if needed.
gramps
 
Joined: 18 Oct 2018

Re: Moving camera breaks titlemap menu

Postby _mental_ » Thu Jan 24, 2019 1:10 am

gramps wrote:Will create a test map when I have more time if needed.

Please do.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: Moving camera breaks titlemap menu

Postby gramps » Thu Jan 24, 2019 1:44 am

Huh, this is weird... it only does this when the ceiling is a sky. When it's a flat texture, the bug doesn't happen.

This is the titlemap I was messing with, so it's probably more detailed than necessary to show the bug, sorry about that.

Try opening it in a map editor and set the ceiling to one of the wall textures or something, bug goes away.

Also, sky texture needs to be defined in mapinfo, or you get the blue and white checkered texture. Not sure if that could be relevant or if that's how it worked before. And something seems to be wrong with the way the sky renders, didn't notice this before, had the sky blacked out. But when the menu glitch happens, the sky jumps from one screwed up rendering to another. This may actually have something to do with hitting portal limit, not sure. Hard to describe, check out demo.
Attachments
menubug.7z
(2.96 KiB) Downloaded 14 times
gramps
 
Joined: 18 Oct 2018

Re: Moving camera breaks titlemap menu

Postby _mental_ » Thu Jan 24, 2019 4:32 am

This is a bug in OpenGL renderer. It has nothing to do with moving cameras, menus, or timemaps.

The problem was introduced with this commit.
Debug build has another indication that something went wrong, a failure of this assertion.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: Moving camera breaks titlemap menu

Postby gramps » Thu Jan 24, 2019 3:31 pm

Actually, if you uncomment that fade in the acs script, you'll notice that breaks too when the bug happens... it suddenly jumps to no fade. Might have to extend the length of that fade a bit to see it.

So maybe it affects all stuff drawn to HUD, like menu and fade.

How did you track it to that commit?
gramps
 
Joined: 18 Oct 2018

Re: Moving camera breaks titlemap menu

Postby _mental_ » Thu Jan 24, 2019 3:56 pm

gramps wrote:How did you track it to that commit?

By doing Git bisect between g3.6.0 and g3.7.0 tags.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: Moving camera breaks titlemap menu

Postby gramps » Thu Jan 24, 2019 4:51 pm

I meant, are you doing that manually or do you have a setup for `git bisect run` to check the assert that failed or something?
gramps
 
Joined: 18 Oct 2018

Re: Moving camera breaks titlemap menu

Postby _mental_ » Fri Jan 25, 2019 1:15 am

Manually. Some commits don’t compile or don’t run, they should be skipped or fixed by hand.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: Moving camera breaks titlemap menu

Postby Graf Zahl » Sun Mar 03, 2019 7:23 am

Fixed the cause of the glitch - but this map's portal setup is bound to cause recursion issues no matter what. This creates a huge amount of portal viewpoints to render which for me peaked at ~900 depending on the angle. Even over 4 iterations it's an exponential growth with a base of roughly 6. And 6*6*6*6 is 1296.

I'm sorry but you'll have to rework the map, this cannot work without render errors and performance degradation.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest