[4.3.1] Additive Shaded renderstyle for UDMF things bugged

Moderator: GZDoom Developers

Forum rules
Please construct and post a simple demo whenever possible for all bug reports. Please provide links to everything.

If you can include a wad demonstrating the problem, please do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

Please make a new topic for every bug. Don't combine multiple bugs into a single topic. Thanks!

[4.3.1] Additive Shaded renderstyle for UDMF things bugged

Postby Jimmy » Sun Apr 19, 2020 10:37 am

Somewhere between 4.2.4 and 4.3.1 the way the Additive Shaded renderstyle was rendered was changed, and it doesn't look good.

See the following example:

- Load this test map (Heretic IWAD to get the textures to load).
- In 4.2.4, the cloud appears properly colored, and with the correct translucency alpha applied.
- In 4.3.1, the cloud's color is washed out and bright, and the translucency is incorrect.
- Notice that a colored sector fade makes the effect appear worse - almost palette-garbled.

fogtest.wad


Screenshots of the test map and of the clouds in their proper context:

4.2.4:
Image
Image

4.3.1:
Image
Image
You do not have the required permissions to view the files attached to this post.
User avatar
Jimmy
 
 
 
Joined: 10 Apr 2006
Discord: Jimmy#4100
Twitch ID: JimmySquared
Operating System: Windows 10/8.1/8/201x 64-bit

Re: [4.3.1] Additive Shaded renderstyle for UDMF things bugg

Postby drfrag » Mon Apr 20, 2020 6:04 am

I've done some investigation and the first version affected is g4.3pre-358-g236b47693 (the second i've tried).
It's the same commit which introduced this bug: viewtopic.php?f=56&t=68042
Code: Select allExpand view
- change ProjectedWallTexcoords to use gradients for its texture coordinate calculations
- change SpriteDrawerArgs to draw a full sprite instead of one column at a time
- add r_noaccel cvar to allow forced software rendering of the psprites (useful for debugging and also one person on the forum actually requested this feature)
- remove FWallTmapVals and calculate texture coordinates directly from FWallCoords
- move portal clipping out of the inner sprite drawing loop

https://github.com/coelckers/gzdoom/com ... 96b7817952
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666


Return to Classic ("Carmack") Software Renderer Bugs

Who is online

Users browsing this forum: No registered users and 0 guests