Multithread sw render buffer overflow

Moderator: GZDoom Developers

Forum rules
Please construct and post a simple demo whenever possible for all bug reports. Please provide links to everything.

If you can include a wad demonstrating the problem, please do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

Please make a new topic for every bug. Don't combine multiple bugs into a single topic. Thanks!

Multithread sw render buffer overflow

Postby Edward-san » Sat Mar 02, 2019 3:12 pm

The titlemap of Square1 makes GZDoom multithread sw renderer (except vid_rendermode 0) instantaneously crash with the address sanitizer, as seen below:

Spoiler:


I got the values of the args of the crashing function:

Code: Select allExpand view
(uint32_t) width = 32
(uint32_t) height = 32
(uint32_t) xone = 134217728
(uint32_t) yone = 134217728
(uint32_t) xstep = 39396284
(uint32_t) ystep = 0
(uint32_t) xfrac = 786861999
(uint32_t) yfrac = 1632337501
(const uint32_t *) source = 0x00006290018d2200
Edward-san
Mathematics is the language with which God has written the universe. (Galilei)
 
Joined: 17 Oct 2009

Re: Multithread sw render buffer overflow

Postby Rachael » Sat Mar 02, 2019 3:37 pm

These are very difficult to solve.

At one point, it was the fog boundaries causing it, and that was fixed, and while it did mitigate some of the crashing it did not fix all of it.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle


Return to Software Renderer Bugs

Who is online

Users browsing this forum: No registered users and 1 guest