Z-Offsets for Voxels

These are not rejected - but are not considered highly important right now.

Moderator: Developers

Z-Offsets for Voxels

Postby hfc2x » Tue Nov 13, 2012 11:03 pm

Just like 3D Models have a ZOffset property, Voxels also need one. It's not like we are gonna open Slab6 to modify a Voxel every time we want to change the offsets, so shifting the ofsets via a property would be a good idea.
User avatar
hfc2x
 
Joined: 17 Aug 2009
Location: Chule

Re: Z-Offsets for Voxels

Postby Graf Zahl » Sun Feb 26, 2017 4:20 pm

This needs some input how to implement in the refactored software renderer. The rest should be simple.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Z-Offsets for Voxels

Postby dpJudas » Sun Feb 26, 2017 5:33 pm

If we are talking about adding a value to the Z position of the voxel, then I think this is done in RenderVoxel::Project (r_voxel.cpp) by adding something to the 'pos' variable before it is stored in the vis object.

There's a line in there already saying this: "pos.Z -= thing->Floorclip". I'm assuming this is just another line added right after that.

Is this offset in world space or model space? If it needs to be in model space, then voxels already got a Pivot member. Implementing it in model space is probably a question of finding the places where Pivot is accessed in that file and add the new offset to the variable it copies Pivot.Z to.
dpJudas
 
 
 
Joined: 28 May 2016

Re: Z-Offsets for Voxels

Postby Graf Zahl » Sun Feb 26, 2017 5:36 pm

It needs to be added to the pivot, but I do not want to touch this before the merge so it got moved to 'on hold'.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to On Hold Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest