Page 1 of 1

Passing variables to "out" Vector2/3 parameters doesn't work

PostPosted: Fri Nov 15, 2019 11:26 am
by phantombeta
As it says in the thread title, you can't pass variables as to Vector2/3 out parameters. Turns out there's some other issue my fix doesn't deal with. Heap-allocated values (e.g., member variables) can be passed just fine, while stack-allocated values (e.g., local variables) just crash GZDoom.
There seems to be two issues - First, it seems like it may still be calculating the wrong amount of parameters in the function call code. Second, there must be some issue where it doesn't correctly calculate or pass the vector's memory address.

Re: Passing variables to "out" Vector2/3 parameters doesn't

PostPosted: Mon Jan 27, 2020 9:01 am
by phantombeta
Turns out the reason for this is that, when it's a FxLocalVariable, it still emits shit as if it were a vector instead of a pointer. FxStructMember (used for struct and class members) works, though, so I'm not sure what the hell's up with this.
I have no idea how to deal with this crap.

Re: Passing variables to "out" Vector2/3 parameters doesn't

PostPosted: Mon Jan 27, 2020 9:31 am
by Major Cooke
Well, if it works for structs being treated as pointers, would it be possible to export DVector2/3 to ZScript somehow? That would allow for treating it like a pointer then, though that might ax any possibility of adding dynamic array support for it.